Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"catch-all" endpoint doesn't work with static_url_path="/" #5527

Closed
DRMPN opened this issue Jul 12, 2024 · 1 comment
Closed

"catch-all" endpoint doesn't work with static_url_path="/" #5527

DRMPN opened this issue Jul 12, 2024 · 1 comment

Comments

@DRMPN
Copy link

DRMPN commented Jul 12, 2024 •
edited
Loading

Catch all endpoint for SPA from docs doesn't work with static_url_path="/" or static_url_path=""

Context

I'm using Flask to serve React SPA with client-side routing.
Flask worked perfectly, until I added images and decided to serve it from static/ folder.

Expected:

I can serve images from static/ folder.
I can reload a non-root page and Flask won't respond with 404 Not Found.

Current:

I can navigate to /path or /path1/path2 and etc. with no problems, but when I reload any non-root page the Flask gives me 404 Not Found and the catch-all route didn't trigger.

Example:

folder structure

.
├── __init__.py
└── main/
    ├── static/
    │   ├── image1.jpg
    │   ├── image2.jpg
    │   ├── index.html
    │   └── main.js
    ├── __init__.py
    └── routes.py

./__init__.py

def create_app(config_class=Config) -> Flask:
  app = Flask(__name__)
  from .main import bp as main_bp
  app.register_blueprint(main_bp)
  return app

./main/__init__.py

from flask import Blueprint

bp = Blueprint("main", __name__, static_folder="static", static_url_path="/")

from .main import routes

./main/routes.py

from .main import bp

@bp.route("/", defaults={"path": ""})
@bp.route("/<path:path>")
def catch_all(path):
    return bp.send_static_file("index.html")

Error message

<!doctype html>
<html lang=en>
<title>404 Not Found</title>
<h1>Not Found</h1>
<p>The requested URL was not found on the server. If you entered the URL manually please check your spelling and try again.</p>

Environment:

  • Python version: Python 3.9.2
  • Flask version: Flask 2.2.5
@davidism
Copy link
Member

The static route is a catch-all path, it matches all paths below it. You need a prefix like /static to distinguish it if you have another top-level catch-all path.

@davidism davidism closed this as not planned Won't fix, can't repro, duplicate, stale Jul 14, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@davidism @DRMPN