Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PROVIDE_AUTOMATIC_OPTIONS causes KeyError if not set #5642

Closed
develerltd opened this issue Nov 14, 2024 · 3 comments
Closed

PROVIDE_AUTOMATIC_OPTIONS causes KeyError if not set #5642

develerltd opened this issue Nov 14, 2024 · 3 comments

Comments

@develerltd
Copy link

https://github.com/pallets/flask/blob/bc098406af9537aacc436cb2ea777fbc9ff4c5aa/src/flask/sansio/app.py#L641C12-L641C86

Simply changing this to : self.config.get("PROVIDE_AUTOMATIC_OPTIONS", False) should resolve the problem.

This change now released is causing upstream trouble in other packages such as Quart:
pallets/quart#371

@davidism
Copy link
Member

Duplicate of pallets/quart#371

@davidism davidism marked this as a duplicate of pallets/quart#371 Nov 14, 2024
@davidism davidism closed this as not planned Won't fix, can't repro, duplicate, stale Nov 14, 2024
@develerltd
Copy link
Author

This is not a duplicate as this is a separate project.

Anything that doesn't pin to flask 3.0.* will be broken by this change.

The fix is simple, as far as I am aware

@pallets pallets locked as resolved and limited conversation to collaborators Nov 14, 2024
@davidism
Copy link
Member

Quart 0.19.9 is now available on PyPI.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants