-
-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Parquet udfs take in PgRelation
#209
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
faab4c6
to
34f46d4
Compare
34f46d4
to
d4a6a22
Compare
A schema difference was detected. A suggested "upgrade.sql" script entry might be: DROP FUNCTION IF EXISTS parquet_describe(files text);
CREATE OR REPLACE FUNCTION parquet_describe(relation regclass) RETURNS TABLE(column_name text, column_type text, "null" text, key text, "default" text, extra text) AS 'MODULE_PATHNAME', 'parquet_describe_wrapper' LANGUAGE c STRICT;
DROP FUNCTION IF EXISTS parquet_schema(files text);
CREATE OR REPLACE FUNCTION parquet_schema(relation regclass) RETURNS TABLE(file_name text, name text, type text, type_length text, repetition_type text, num_children pg_catalog.int8, converted_type text, scale pg_catalog.int8, "precision" pg_catalog.int8, field_id pg_catalog.int8, logical_type text) AS 'MODULE_PATHNAME', 'parquet_schema_wrapper' LANGUAGE c STRICT; The full diff between both schemas is:217c217
< -- src/api/parquet.rs:48
---
> -- src/api/parquet.rs:52
220c220
< "files" TEXT /* &str */
---
> "relation" regclass /* pgrx::rel::PgRelation */
270c270
< -- src/api/parquet.rs:66
---
> -- src/api/parquet.rs:73
273c273
< "files" TEXT /* &str */
---
> "relation" regclass /* pgrx::rel::PgRelation */ |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket(s) Closed
What
Instead of taking in the file strings,
parquet_schema
andparquet_describe
take in the foreign table relation, which allows us to load in the user mapping options.BEFORE:
AFTER:
Why
Fixes a bug where user mapping options were not getting loaded in to new sessions.
How
Tests