- Breaking change: Require Node 8

- Refactoring: Use ES6 classes
- Travis: Add Node 11 and 12
- Linting: Add eslint-config-ash-nazg (and remove jshint) to JS, Markdown, HTML
- npm: Add `package-lock.json`
- npm: Add recommended fields (contributors, homepage)
- npm: Change deprecated `licenses` with `license`
- npm: Add `lint` and `lintfix` scripts
- npm: Update link from http to https
- npm: Update chai, mocha

Author: brettz9

.eslintignore

@@ -0,0 +1,4 @@
+.git
+coverage/
+node_modules/
+var/

.eslintrc.js

@@ -0,0 +1,101 @@
+module.exports = {
+    env: {
+      node: true,
+      browser: false
+    },
+    extends: [
+      'ash-nazg/sauron-node',
+      // Override ash-nazg's current preference for ESM
+      'plugin:node/recommended-script'
+    ],
+    settings: {
+      polyfills: [
+      ]
+    },
+    overrides: [
+      {
+        files: ['test/*'],
+        env: {
+          mocha: true
+        },
+        globals: {
+          expect: 'readonly'
+        },
+        rules: {
+          'func-names': 0
+        }
+      },
+      {
+        files: ['**/*.md'],
+        rules: {
+          'eol-last': 'off',
+          'no-console': 'off',
+          'no-undef': 'off',
+          'no-unused-vars': 'warn',
+          'padded-blocks': 'off',
+          'import/unambiguous': 'off',
+          'import/no-unresolved': 'off',
+          'node/no-missing-import': 'off',
+          'node/no-missing-require': 'off',
+          'func-names': 'off',
+          'import/newline-after-import': 'off',
+          'no-unused-vars': ['error', {varsIgnorePattern: 'CustomStrategy'}],
+          strict: 'off',
+          // Disable until eslint-plugin-jsdoc may fix: https://github.com/gajus/eslint-plugin-jsdoc/issues/211
+          indent: 'off'
+        }
+      }
+    ],
+    globals: {
+      // By some ESLint bug, config overrides not working with globals
+      require: 'readonly',
+      module: 'readonly',
+      exports: 'writable'
+    },
+    rules: {
+      'comma-dangle': 0,
+      'no-underscore-dangle': 0,
+      'no-param-reassign': 0,
+
+      // Disable current preferences of ash-nazg
+      'import/no-commonjs': 0,
+      'node/exports-style': 0,
+
+      // Browser only
+      'compat/compat': 0,
+
+      // add back different or stricter rules from airbnb
+      'object-curly-spacing': ['error', 'always'],
+      'func-names': 'warn',
+      'max-len': ['error', 100, 2, {
+        ignoreUrls: true,
+        ignoreComments: false,
+        ignoreRegExpLiterals: true,
+        ignoreStrings: true,
+        ignoreTemplateLiterals: true,
+      }],
+      'space-before-function-paren': ['error', {
+        anonymous: 'always',
+        named: 'never',
+        asyncArrow: 'always'
+      }],
+      'no-multiple-empty-lines': ['error', { max: 2, maxEOF: 0 }],
+      'arrow-parens': ['error', 'as-needed', {
+        requireForBlockBody: true,
+      }],
+      'no-empty-function': ['error', {
+        allow: [
+          'arrowFunctions',
+          'functions',
+          'methods',
+        ]
+      }],
+      'no-unused-vars': ['error', { vars: 'all', args: 'after-used', ignoreRestSiblings: true }],
+      'no-multi-assign': ['error'],
+      'no-unused-expressions': ['error', {
+        allowShortCircuit: false,
+        allowTernary: false,
+        allowTaggedTemplates: false,
+      }]
+    }
+  };

.jshintrc

@@ -19,6 +19,5 @@ npm-debug.log
 .git*
 
 # Utilities
-.jshintrc
 .travis.yml
 .gitlab-ci.yml

.npmignore

@@ -1,8 +1,9 @@
 language: "node_js"
 node_js:
-  - "6"
   - "8"
   - "10"
+  - "11"
+  - "12"
 
 before_install:
  - "npm install istanbul -g"

.travis.yml

@@ -4,4 +4,3 @@
 * Updated travis to use node 6, 8 and 10 @rwky
 * Updated dev deps @rwky
 * Updated README.md and package.json for passport-next org
-

CHANGELOG.md

@@ -11,7 +11,9 @@ API.
 
 ## Install
 
-    $ npm install passport-strategy
+```
+npm install passport-strategy
+```
 
 ## Usage
 
@@ -25,14 +27,14 @@ middleware for authentication.
 Create a new `CustomStrategy` constructor which inherits from `Strategy`:
 
 ```javascript
-var util = require('util')
-  , Strategy = require('@passport-next/passport-strategy');
+const Strategy = require('@passport-next/passport-strategy');
 
-function CustomStrategy(...) {
-  Strategy.call(this);
+class CustomStrategy extends Strategy {
+  constructor(/* ... */) {
+    super();
+    doSomething();
+  }
 }
-
-util.inherits(CustomStrategy, Strategy);
 ```
 
 #### Implement Authentication
@@ -41,8 +43,12 @@ Implement `autheticate()`, performing the necessary operations required by the
 authentication scheme or protocol being implemented.
 
 ```javascript
-CustomStrategy.prototype.authenticate = function(req, options) {
-  // TODO: authenticate request
+class CustomStrategy {
+  // ...
+  authenticate(req, options) {
+    // TODO: authenticate request
+    this._authenticateRequest(req, options);
+  }
 }
 ```
 
@@ -75,8 +81,8 @@ details.
 
 | Param | Type |
 | --- | --- |
-| user | Object | 
-| info | Object | 
+| user | Object |
+| info | Object |
 
 
 ##### strategy.fail(challenge, status)
@@ -90,8 +96,8 @@ Strategies should call this function to fail an authentication attempt.
 
 | Param | Type |
 | --- | --- |
-| challenge | String | 
-| status | Number | 
+| challenge | String |
+| status | Number |
 
 
 
@@ -106,8 +112,8 @@ user agent) to a third-party website for authentication.
 
 | Param | Type |
 | --- | --- |
-| url | String | 
-| status | Number | 
+| url | String |
+| status | Number |
 
 
 ##### strategy.pass()
@@ -132,7 +138,7 @@ user directory is not available.
 
 | Param | Type |
 | --- | --- |
-| err | Error | 
+| err | Error |
 
 
 
@@ -144,4 +150,3 @@ user directory is not available.
 
     $ npm install
     $ npm test
-

README.md

@@ -1,12 +1,14 @@
+'use strict';
 /**
  * Module dependencies.
  */
-var Strategy = require('./strategy');
+const Strategy = require('./strategy');
 
 
 /**
  * Expose `Strategy` directly from package.
  */
+// eslint-disable-next-line no-multi-assign
 exports = module.exports = Strategy;
 
 /**

lib/index.js

@@ -1,27 +1,26 @@
+'use strict';
 /**
  * Creates an instance of `Strategy`.
  *
- * @constructor
- * @api public
+ * @public
  */
-function Strategy() {
+class Strategy {
+  /**
+   * Authenticate request.
+   *
+   * This function must be overridden by subclasses.  In abstract form, it always
+   * throws an exception.
+   *
+   * @param {Object} req The request to authenticate.
+   * @param {Object} [options] Strategy-specific options.
+   * @public
+   * @returns {void}
+   */
+  authenticate(req, options) { // eslint-disable-line no-unused-vars, class-methods-use-this
+    throw new Error('Strategy#authenticate must be overridden by subclass');
+  }
 }
 
-/**
- * Authenticate request.
- *
- * This function must be overridden by subclasses.  In abstract form, it always
- * throws an exception.
- *
- * @param {Object} req The request to authenticate.
- * @param {Object} [options] Strategy-specific options.
- * @api public
- */
-Strategy.prototype.authenticate = function(req, options) {
-  throw new Error('Strategy#authenticate must be overridden by subclass');
-};
-
-
 /**
  * Expose `Strategy`.
  */