- Linting (ESLint): Avoid "useless" catch error; adhere to stricter jsdoc context checking

- Minor fixes for template files for gitignore/package.json/README
- npm: update devDeps

Author: brettz9

.eslintrc.js

@@ -5,7 +5,7 @@ module.exports = {
     },
     extends: [
       '@passport-next/eslint-config-passport-next/sauron-node.js',
-      // Override ash-nazg's current preference for ESM
+      // Override eslint-config-passport-next's current preference for ESM
       'plugin:node/recommended-script'
     ],
     settings: {
@@ -74,7 +74,7 @@ module.exports = {
       // Disable until ready to tackle
       'require-jsdoc': 0,
 
-      // Disable current preferences of ash-nazg
+      // Disable current preferences of eslint-config-passport-next
       'import/no-commonjs': 0,
       'node/exports-style': 0,
 

.gitignore

@@ -1,6 +1,5 @@
 reports/
 docs/jsdoc
-.github/docs/jsdoc
 var/
 
 

lib/http/request.js

@@ -32,6 +32,7 @@ const req = exports = module.exports = {};
  *     try {
  *      await req.logIn(user);
  *     } catch (err) {
+ *      console.error(err);
  *      throw err;
  *     }
  *     // session saved

lib/index.js

@@ -32,14 +32,18 @@ const SessionStrategy = require('./strategies/session');
 * @typedef {external:HttpServerResponse} Response
 */
 
+/**
+* @external ConnectNextCallback
+*/
+
 /**
  * This middleware conforms to Connect/Express middleware by
  * the arguments it accepts.
  * @see Conforms to {@link external:ConnectMiddleware}
  * @callback ConnectMiddleware
  * @param {Request} req
  * @param {Response} res
- * @param {Function} next
+ * @param {ConnectNextCallback} next
  * @returns {void}
 */
 

lib/middleware/authenticate.js

@@ -18,10 +18,10 @@ const AuthenticationError = require('../errors/authenticationerror');
 * @param {Error|null} error
 * @param {false|User} user Set to the authenticated user on a successful
 *   authentication attempt, or `false` otherwise.
-* @param {*} [info] Contains additional details provided by the strategy's verify
+* @param {Any} [info] Contains additional details provided by the strategy's verify
 * callback - this could be information about a successful authentication or a
 * challenge message for a failed authentication.
-* @param {*} [status] Passed when authentication fails - this could
+* @param {Any} [status] Passed when authentication fails - this could
 *   be an HTTP response code for a remote authentication failure or similar.
 * @returns {void}
 * @example
@@ -329,6 +329,7 @@ module.exports = function authenticate(passport, name, options, callback) {
         if (options.authInfo !== false) {
           try {
             const tinfo = await passport.transformAuthInfo(info, req);
+            // eslint-disable-next-line require-atomic-updates
             req.authInfo = tinfo;
             complete();
           } catch (err) {

lib/sessionmanager.js

@@ -55,6 +55,7 @@ class SessionManager {
       }
       return;
     }
+    /* eslint-disable require-atomic-updates */
     if (!req._passport.session) {
       req._passport.session = {};
     }
@@ -63,6 +64,7 @@ class SessionManager {
       req.session = {};
     }
     req.session[this._key] = req._passport.session;
+    /* eslint-enable require-atomic-updates */
     // eslint-disable-next-line no-unused-expressions
     cb && cb();
   }

lib/strategies/session.js

@@ -85,6 +85,7 @@ class SessionStrategy extends Strategy {
       } else {
         // TODO: Remove instance access (set by `initialize`)
         const property = req._passport.instance._userProperty || 'user';
+        // eslint-disable-next-line require-atomic-updates
         req[property] = user;
       }
       this.pass();