Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Chart LESS to Patternfly core #685

Open
dtaylor113 opened this issue Dec 7, 2017 · 0 comments
Open

Update Chart LESS to Patternfly core #685

dtaylor113 opened this issue Dec 7, 2017 · 0 comments

Comments

@dtaylor113
Copy link
Member

Part of #676

Review: https://github.com/patternfly/angular-patternfly/blob/master/src/charts/charts.less

Donut Chart
DonutPctChart
Line Chart
Sparkline Chart
Topology
Heat Map
Trends Chart
Utilization Bar Chart
Utilization Trend Chart.

I'd recommend taking a screenshot of each chart as it is now in a-pf, and a screenshot of how it is in PF.org and/or test pages. Also get the LESS/CSS used in both repos side by side to compare. Make changes in angular-patternfly, possibly more LESS into PF core. When done take another screenshot of changes and compare to original screenshots.

@dtaylor113 dtaylor113 self-assigned this Dec 7, 2017
@dtaylor113 dtaylor113 removed their assignment Jun 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant