Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Popper positioning enhancements #11155

Open
tlabaj opened this issue Oct 31, 2024 · 1 comment
Open

Popper positioning enhancements #11155

tlabaj opened this issue Oct 31, 2024 · 1 comment

Comments

@tlabaj
Copy link
Contributor

tlabaj commented Oct 31, 2024

Describe the enhancement or change
A clear and concise description of the request. What is the expected outcome?

A consumer request form slack thread RHOAI
...
as for the positioning of the arrow, it would be nice if PF could support the feature that comes from popper. But it’s not just the positioning of the arrow, it’s positioning of the content box itself to stay visible in the viewport if there’s enough space instead of pushing out of the viewport boundary and causing scroll bars to appear on the body.

@ibolton336
Copy link
Member

@tlabaj I am not able to see the popperProps position take effect. The Direction seems to work, but position isn't functional for me.

   <Dropdown
      className="violation-actions-dropdown"
      id="violation-actions-dropdown-id"
      isOpen={isOpen}
      onSelect={() => setIsOpen(false)}
      popperProps={{
        appendTo: document.body,
        position: "left",
        direction: "up",
        enableFlip: false,
      }}


@tlabaj tlabaj removed the PF Team label Nov 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Needs triage
Development

No branches or pull requests

2 participants