Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split/Stack layouts - add support for component prop on items #11169

Open
mcoker opened this issue Nov 7, 2024 · 0 comments · May be fixed by #11170
Open

Split/Stack layouts - add support for component prop on items #11169

mcoker opened this issue Nov 7, 2024 · 0 comments · May be fixed by #11170
Assignees
Labels

Comments

@mcoker
Copy link
Contributor

mcoker commented Nov 7, 2024

I noticed <StackItem /> and <SplitItem /> always render as a <div> but their parents (<Stack /> and <Split />) allow for a component prop that lets you specify what element to use. If you do something like <Stack component="span"><StackItem>, you'll get <span><div>, which is invalid HTML. We should allow for customization on the element rendered as the split/stack items.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: PR Review
Development

Successfully merging a pull request may close this issue.

1 participant