From d9f1475652020a0e3e1546492f90cd693c88038d Mon Sep 17 00:00:00 2001 From: Krishna Date: Fri, 2 Aug 2024 13:34:16 +0530 Subject: [PATCH 1/4] Filter comparison handle upcase and downcase --- lib/query_helper/sql_filter.rb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/query_helper/sql_filter.rb b/lib/query_helper/sql_filter.rb index d512ef6..2b90bb8 100644 --- a/lib/query_helper/sql_filter.rb +++ b/lib/query_helper/sql_filter.rb @@ -17,7 +17,7 @@ def create_filters @filter_values.each do |comparate_alias, criteria| # Find the sql mapping if it exists - map = @column_maps.find { |m| m.alias_name == comparate_alias } + map = @column_maps.find { |m| m.alias_name.downcase == comparate_alias.downcase } raise InvalidQueryError.new("cannot filter by #{comparate_alias}") unless map # create the filter From dc40417f6771ba36d2d7f7202d708d9e469b9f6d Mon Sep 17 00:00:00 2001 From: Krishna Date: Mon, 5 Aug 2024 11:40:15 +0530 Subject: [PATCH 2/4] Make search column name case insensitive --- lib/query_helper.rb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/query_helper.rb b/lib/query_helper.rb index bd8b1f1..f697ff9 100644 --- a/lib/query_helper.rb +++ b/lib/query_helper.rb @@ -281,7 +281,7 @@ def search_filter(column_maps) placement = :where maps = column_maps.select do |cm| placement = :having if cm.aggregate - @search_fields.include? cm.alias_name + @search_fields.map(&:downcase).include? cm.alias_name.downcase end bind_variable = ('a'..'z').to_a.shuffle[0,20].join.to_sym @bind_variables[bind_variable] = "%#{@search_string}%" From 5cd8370a9163b0cb4ac2dfa09521d1354bd775ee Mon Sep 17 00:00:00 2001 From: Krishna Date: Mon, 5 Aug 2024 11:40:15 +0530 Subject: [PATCH 3/4] Make search column name case insensitive --- lib/query_helper.rb | 2 +- lib/query_helper/version.rb | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/query_helper.rb b/lib/query_helper.rb index bd8b1f1..f697ff9 100644 --- a/lib/query_helper.rb +++ b/lib/query_helper.rb @@ -281,7 +281,7 @@ def search_filter(column_maps) placement = :where maps = column_maps.select do |cm| placement = :having if cm.aggregate - @search_fields.include? cm.alias_name + @search_fields.map(&:downcase).include? cm.alias_name.downcase end bind_variable = ('a'..'z').to_a.shuffle[0,20].join.to_sym @bind_variables[bind_variable] = "%#{@search_string}%" diff --git a/lib/query_helper/version.rb b/lib/query_helper/version.rb index aae9cd6..258d35d 100644 --- a/lib/query_helper/version.rb +++ b/lib/query_helper/version.rb @@ -1,3 +1,3 @@ class QueryHelper - VERSION = "0.3.6" + VERSION = "0.3.7" end From 0185723572d882892828a080ff3628afd256a32c Mon Sep 17 00:00:00 2001 From: Krishna Date: Mon, 5 Aug 2024 21:27:39 +0530 Subject: [PATCH 4/4] Merge remote-tracking branch 'origin/fix-make_sql_filter_case_insensitive' into fix-make_sql_filter_case_insensitive --- Gemfile.lock | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Gemfile.lock b/Gemfile.lock index 47c4e60..f6be4db 100644 --- a/Gemfile.lock +++ b/Gemfile.lock @@ -89,7 +89,7 @@ GEM rspec-mocks (~> 3.10) rspec-support (~> 3.10) rspec-support (3.10.2) - sqlite3 (2.0.3) + sqlite3 (1.6.4) mini_portile2 (~> 2.8.0) thor (1.1.0) tzinfo (2.0.4)