Code Polish

Author: kevinverschoor

Block/Page/FastCheckoutFallback.php

@@ -12,7 +12,6 @@
 
 class FastCheckoutFallback extends \Magento\Framework\View\Element\Template
 {
-
     /**
      * @var Request
      */
@@ -73,7 +72,6 @@ public function __construct(
      * @return string
      */
     protected function _beforeToHtml() // phpcs:ignore
-
     {
         return parent::_beforeToHtml();
     }

Controller/Checkout/FastCheckoutStart.php

@@ -78,6 +78,7 @@ public function __construct(
 
     /**
      * @param quote $quote
+     * @param array $params
      * @return void
      * @phpcs:disable Squiz.Commenting.FunctionComment.TypeHintMissing
      */
@@ -131,7 +132,7 @@ private function quoteSetDummyData($quote, $params)
                     throw new \Exception('Shipping method not availeble', FastCheckoutStart::FC_ESITMATE_ERROR);
                 }
             }
-            if (isset($params['selected_estimate_shipping']) && !empty($params['selected_estimate_shipping']) && !empty($shippingMethodsAvaileble[$params['selected_estimate_shipping']]) && $store->getConfig('payment/paynl_payment_ideal/fast_checkout_use_estimate_selection') > 0) {
+            if (isset($params['selected_estimate_shipping']) && !empty($params['selected_estimate_shipping']) && !empty($shippingMethodsAvaileble[$params['selected_estimate_shipping']]) && $store->getConfig('payment/paynl_payment_ideal/fast_checkout_use_estimate_selection') > 0) { // phpcs:ignore
                 $shippingMethod = $params['selected_estimate_shipping'];
             } elseif (!empty($shippingMethodsAvaileble[$store->getConfig('payment/paynl_payment_ideal/fast_checkout_shipping')])) {
                 $shippingMethod = $store->getConfig('payment/paynl_payment_ideal/fast_checkout_shipping');
@@ -187,9 +188,7 @@ private function getProducts()
     }
 
     /**
-     * @param quote $quote
      * @return void
-     * @phpcs:disable Squiz.Commenting.FunctionComment.TypeHintMissing
      */
     public function cacheShippingMethods()
     {
@@ -227,7 +226,7 @@ public function execute()
                 }
             }
 
-            if (empty($store->getConfig('payment/paynl_payment_ideal/fast_checkout_shipping')) && (!isset($params['fallbackShippingMethod']) || empty($params['fallbackShippingMethod'])) && (!isset($params['selected_estimate_shipping']) || empty($params['selected_estimate_shipping']))) {
+            if (empty($store->getConfig('payment/paynl_payment_ideal/fast_checkout_shipping')) && (!isset($params['fallbackShippingMethod']) || empty($params['fallbackShippingMethod'])) && (!isset($params['selected_estimate_shipping']) || empty($params['selected_estimate_shipping']))) { // phpcs:ignore
                 throw new \Exception('No shipping method selected', FastCheckoutStart::FC_SHIPPING_ERROR);
             }
 

ViewModel/FastCheckout.php

@@ -2,9 +2,9 @@
 
 namespace Paynl\Payment\ViewModel;
 
+use Magento\Customer\Model\Session;
 use Magento\Framework\View\Element\Block\ArgumentInterface;
 use Magento\Store\Model\StoreManagerInterface;
-use Magento\Customer\Model\Session;
 
 class FastCheckout implements ArgumentInterface
 {
@@ -20,7 +20,8 @@ class FastCheckout implements ArgumentInterface
 
     /**
      * BuyNow constructor.
-     * @param ScopeConfigInterface $scopeConfig
+     * @param StoreManagerInterface $storeManager
+     * @param Session $session
      */
     public function __construct(
         StoreManagerInterface $storeManager,
@@ -30,15 +31,15 @@ public function __construct(
         $this->session = $session;
     }
 
-    /**  
-     * @return string
+    /**
+     * @return boolean
      */
     public function getVisibility()
     {
         $store = $this->storeManager->getStore();
-        if($this->session->isLoggedIn() && $store->getConfig('payment/paynl_payment_ideal/fast_checkout_guest_only') == 1) {
+        if ($this->session->isLoggedIn() && $store->getConfig('payment/paynl_payment_ideal/fast_checkout_guest_only') == 1) {
             return false;
         }
-        return true;     
+        return true;
     }
 }