squash! BUG: Rewrite inspect.unwrap() to respect classes

Remove argument `stop` from `pdoc._unwrap_object()`

Author: USSX-Hares

pdoc/__init__.py

@@ -449,14 +449,13 @@ def _unwrap_descriptor(dobj):
     return getattr(obj, '__get__', obj)
 
 
-def _unwrap_object(obj: T, *, stop: Optional[Callable[[T], bool]] = None) -> T:
+def _unwrap_object(obj: T) -> T:
     """
     This is a modified version of `inspect.unwrap()` that properly handles classes.
 
     Follows the chains of `__wrapped__` attributes, until either:
     1. `obj.__wrapped__` is missing or None
     2. `obj` is a class and `obj.__wrapped__` has a different name or module
-    3. `stop` is given and `stop(obj)` is True
     """
 
     orig = obj  # remember the original func for error reporting
@@ -465,9 +464,6 @@ def _unwrap_object(obj: T, *, stop: Optional[Callable[[T], bool]] = None) -> T:
     memo = {id(orig): orig}
     recursion_limit = sys.getrecursionlimit()
     while hasattr(obj, '__wrapped__'):
-        if stop is not None and stop(obj):
-            break
-
         candidate = obj.__wrapped__
         if candidate is None:
             break
@@ -477,7 +473,7 @@ def _unwrap_object(obj: T, *, stop: Optional[Callable[[T], bool]] = None) -> T:
                     and candidate.__module__ == orig.__module__):
                 break
 
-        obj = candidate
+        obj = typing.cast(T, candidate)
         id_func = id(obj)
         if (id_func in memo) or (len(memo) >= recursion_limit):
             raise ValueError('wrapper loop when unwrapping {!r}'.format(orig))