Skip to content

Commit 86fb8be

Browse files
authored
Merge pull request #344 from pebble/bugfix/kv-table-remove
Fix KV-table row delete regression
2 parents e7e7a6e + a46a993 commit 86fb8be

File tree

2 files changed

+3
-2
lines changed

2 files changed

+3
-2
lines changed

ide/static/ide/js/KVtable.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -54,10 +54,10 @@ CloudPebble.KVTable = function(table_elm, options) {
5454
.attr('placeholder', key ? null : opts.value_placeholder)),
5555
$('<td>').append(
5656
$('<button>')
57-
.prop('disabled', !key))
57+
.prop('disabled', !key)
5858
.text('-')
5959
.addClass("btn kv-remove")
60-
.attr('type', 'button')
60+
.attr('type', 'button'))
6161
]);
6262
self.trigger('rowRendered', row);
6363
return row;

ide/static/ide/js/dependencies.js

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -279,6 +279,7 @@ CloudPebble.Dependencies = (function() {
279279
if (!val) return;
280280
cache.lookup_module(val).then(function(data) {
281281
on_submit(val, data.version ? version_prefix + data.version : null);
282+
return null;
282283
}).catch(function() {
283284
on_submit(val, null);
284285
});

0 commit comments

Comments
 (0)