Skip to content

Commit e64b89b

Browse files
committed
Updated about, hidden accuracy when creating by geouri, alphabetic category order
1 parent fd14eea commit e64b89b

File tree

5 files changed

+25
-2
lines changed

5 files changed

+25
-2
lines changed

app/src/main/java/it/danieleverducci/nextcloudmaps/activity/about/AboutActivity.java

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -62,6 +62,10 @@ private void fillAboutActivity () {
6262
TextView tvIssues = findViewById(R.id.about_issues);
6363
tvIssues.setText(Html.fromHtml(getString(R.string.about_issues, getString(R.string.url_issues))));
6464
tvIssues.setOnClickListener(view -> openUtl(getString(R.string.url_issues)));
65+
66+
TextView tvMaps = findViewById(R.id.about_maps);
67+
tvMaps.setText(Html.fromHtml(getString(R.string.about_maps)));
68+
tvMaps.setOnClickListener(view -> openUtl(getString(R.string.url_maps)));
6569
}
6670

6771
@Override

app/src/main/java/it/danieleverducci/nextcloudmaps/activity/detail/GeofavoriteDetailActivity.java

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -165,6 +165,7 @@ public void onChanged(@Nullable Boolean success) {
165165
double[] coords = GeoUriParser.parseUri(getIntent().getData());
166166
mGeofavorite.setLat(coords[0]);
167167
mGeofavorite.setLng(coords[1]);
168+
mViewHolder.hideAccuracy();
168169
} catch (IllegalArgumentException e) {
169170
Toast.makeText(this, R.string.error_unsupported_uri, Toast.LENGTH_SHORT).show();
170171
finish();
@@ -319,6 +320,7 @@ public ViewHolder(LayoutInflater inflater) {
319320
// Set map properties
320321
this.binding.map.getZoomController().setVisibility(CustomZoomButtonsController.Visibility.NEVER);
321322
this.binding.map.setMultiTouchControls(true);
323+
// this.binding.map.setTilesScaledToDpi(true);
322324

323325
// Create marker
324326
mapMarker = new Marker(binding.map);

app/src/main/java/it/danieleverducci/nextcloudmaps/model/Geofavorite.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -154,7 +154,7 @@ public void setComment(String comment) {
154154
*/
155155
public static Comparator<Geofavorite> ByTitleAZ = (gf0, gf1) -> gf0.name.compareTo(gf1.name);
156156
public static Comparator<Geofavorite> ByLastCreated = (gf0, gf1) -> (int) (gf1.dateCreated - gf0.dateCreated);
157-
public static Comparator<Geofavorite> ByCategory = (gf0, gf1) -> gf0.category.compareTo(gf1.category);
157+
public static Comparator<Geofavorite> ByCategory = (gf0, gf1) -> (gf0.category + gf0.name).compareTo(gf1.category + gf1.name);
158158
public static Comparator<Geofavorite> ByDistance = (gf0, gf1) -> 0; // (int) ((gf1.getDistanceFrom(userPosition) - gf0.getDistanceFrom(userPosition)) * 1000);
159159

160160
public String getCoordinatesString() {

app/src/main/res/layout/activity_about.xml

Lines changed: 14 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -115,6 +115,20 @@
115115
android:layout_height="wrap_content"
116116
android:padding="10dp"
117117
android:text="@string/about_issues" />
118+
119+
<TextView
120+
style="?android:attr/listSeparatorTextViewStyle"
121+
android:layout_width="match_parent"
122+
android:layout_height="wrap_content"
123+
android:text="@string/about_maps_title" />
124+
125+
<TextView
126+
android:id="@+id/about_maps"
127+
style="?android:attr/editTextPreferenceStyle"
128+
android:layout_width="match_parent"
129+
android:layout_height="wrap_content"
130+
android:padding="10dp"
131+
android:text="@string/about_maps" />
118132
</LinearLayout>
119133

120134
</com.google.android.material.appbar.AppBarLayout>

app/src/main/res/values/strings.xml

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -69,6 +69,8 @@
6969
<string name="about_source">This project is hosted on GitHub: &lt;a href="%1$s">%1$s&lt;/a></string>
7070
<string name="about_issues_title">Issues</string>
7171
<string name="about_issues">You can report bugs, enhancement proposals and feature requests at the GitHub issue tracker: &lt;a href="%1$s">%1$s&lt;/a></string>
72+
<string name="about_maps_title">Maps</string>
73+
<string name="about_maps">This app uses Open Street Maps tiles and servers to display the map. I do not accept any donation for this app, but strongly encourage to make any donation to &lt;a href="%1$s">OpenStreetMap&lt;/a>, as this application could not exist without them.</string>
7274
<string name="about_app_license_title">App license</string>
7375
<string name="about_app_license">This application is licensed under the GNU GENERAL PUBLIC LICENSE v3+.</string>
7476
<string name="about_app_license_button">View license</string>
@@ -79,8 +81,9 @@
7981

8082
<!-- URLs -->
8183
<string name="url_source" translatable="false">https://github.com/penguin86/nextcloud-maps-client</string>
82-
<string name="url_issues" translatable="false">https://github.com/penguin86/nextcloud-maps-client/issues/new/choose</string>
84+
<string name="url_issues" translatable="false">https://github.com/penguin86/nextcloud-maps-client/issues</string>
8385
<string name="url_license" translatable="false">https://raw.githubusercontent.com/penguin86/nextcloud-maps-client/master/LICENSE</string>
86+
<string name="url_maps" translatable="false">https://donate.openstreetmap.org</string>
8487

8588
<!-- Settings -->
8689
<string name="setting_sort_by">SETTING_SORT_BY</string>

0 commit comments

Comments
 (0)