Skip to content

Commit bbc183b

Browse files
committed
Removed NoReturn from functions
1 parent 0f8f59d commit bbc183b

7 files changed

Lines changed: 14 additions & 15 deletions

File tree

.github/workflows/python-publish.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -14,9 +14,9 @@ jobs:
1414
permissions:
1515
id-token: write
1616
steps:
17-
- uses: actions/checkout@v4
17+
- uses: actions/checkout@v6
1818
- name: Set up Python
19-
uses: actions/setup-python@v5
19+
uses: actions/setup-python@v6
2020
with:
2121
python-version: '3.x'
2222
- name: Install dependencies

.github/workflows/run-pytest.yml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -9,14 +9,14 @@ jobs:
99
runs-on: ${{ matrix.os }}
1010
strategy:
1111
matrix:
12-
python-version: ["3.8", "3.11"]
12+
python-version: ["3.10", "3.13"]
1313
os: [ubuntu-latest]
1414

1515
steps:
16-
- uses: actions/checkout@v2
16+
- uses: actions/checkout@v6
1717

1818
- name: Set up Python ${{ matrix.python-version }}
19-
uses: actions/setup-python@v2
19+
uses: actions/setup-python@v6
2020
with:
2121
python-version: ${{ matrix.python-version }}
2222

eido/_version.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
__version__ = "0.2.4"
1+
__version__ = "0.2.5"

eido/conversion.py

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,6 @@
77
import inspect
88
from logging import getLogger
99
import os
10-
from typing import NoReturn
1110

1211
from .exceptions import *
1312

@@ -107,7 +106,7 @@ def run_filter(prj, filter_name, verbose=True, plugin_kwargs=None):
107106
return conv_result
108107

109108

110-
def save_result(result_path: str, content: str) -> NoReturn:
109+
def save_result(result_path: str, content: str) -> None:
111110
with open(result_path, "w") as f:
112111
f.write(content)
113112

eido/conversion_plugins.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
""" built-in PEP filters """
1+
"""built-in PEP filters"""
22

33
from typing import Dict
44
from .output_formatters import MultilineOutputFormatter

eido/exceptions.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
""" Exceptions for specific eido issues. """
1+
"""Exceptions for specific eido issues."""
22

33
from abc import ABCMeta
44

eido/validation.py

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
import os
2-
from typing import NoReturn, Mapping, Union
2+
from typing import Mapping, Union
33
from copy import deepcopy as dpcpy
44
from logging import getLogger
55

@@ -60,15 +60,15 @@ def _validate_object(obj: Mapping, schema: Union[str, dict], sample_name_colname
6060
_LOGGER.debug("Validation was successful...")
6161

6262

63-
def validate_project(project: peppy.Project, schema: Union[str, dict]) -> NoReturn:
63+
def validate_project(project: peppy.Project, schema: Union[str, dict]) -> None:
6464
"""
6565
Validate a project object against a schema
6666
6767
:param peppy.Project project: a project object to validate
6868
:param str | dict schema: schema dict to validate against or a path to one
6969
from the error. Useful when used ith large projects
7070
71-
:return: NoReturn
71+
:return: None
7272
:raises EidoValidationError: if validation is unsuccessful
7373
"""
7474
sample_name_colname = project.sample_name_colname
@@ -100,7 +100,7 @@ def _validate_sample_object(sample: peppy.Sample, schemas):
100100

101101
def validate_sample(
102102
project: peppy.Project, sample_name: Union[str, int], schema: Union[str, dict]
103-
) -> NoReturn:
103+
) -> None:
104104
"""
105105
Validate the selected sample object against a schema
106106
@@ -123,7 +123,7 @@ def validate_sample(
123123

124124
def validate_config(
125125
project: Union[peppy.Project, dict], schema: Union[str, dict]
126-
) -> NoReturn:
126+
) -> None:
127127
"""
128128
Validate the config part of the Project object against a schema
129129

0 commit comments

Comments
 (0)