Skip to content

Commit 9c5a7aa

Browse files
committed
Blacklist the 1.8.11-ms-store-11 tag
This version is not available for download. Fixes #30
1 parent bcd65a3 commit 9c5a7aa

File tree

1 file changed

+16
-3
lines changed

1 file changed

+16
-3
lines changed

arduino-ci-script.sh

+16-3
Original file line numberDiff line numberDiff line change
@@ -195,7 +195,7 @@ function install_ide() {
195195
return_handler "$ARDUINO_CI_SCRIPT_FAILURE_EXIT_STATUS"
196196
fi
197197

198-
# Generate an array declaration string containing a list all Arduino IDE versions which support CLI (1.5.2+ according to https://github.com/arduino/Arduino/blob/master/build/shared/manpage.adoc#history)
198+
# Generate an array declaration string containing a list all available Arduino IDE versions which support CLI
199199
# Save the current folder
200200
local -r previousFolder="$PWD"
201201
cd "$ARDUINO_CI_SCRIPT_TEMPORARY_FOLDER"
@@ -204,13 +204,26 @@ function install_ide() {
204204
cd Arduino
205205
git remote add origin https://github.com/arduino/Arduino.git
206206
if [[ "$startIDEversion" != "1.6.2" ]] && [[ "$startIDEversion" != "1.6.2" ]]; then
207-
# Arduino IDE 1.6.2 has the nasty behavior of moving the included hardware cores to the .arduino15 folder, causing those versions to be used for all builds after Arduino IDE 1.6.2 is used. For that reason, 1.6.2 will only be installed if explicitly specified in the install_ide version arguments
207+
# See "Arduino IDE version blacklist" documentation below
208208
local -r IDEversion162regex=--regex='refs/tags/1\.6\.2'
209209
if [[ "$ARDUINO_CI_SCRIPT_VERBOSITY_LEVEL" -gt 0 ]]; then
210210
echo "NOTE: Due to not playing nicely with other versions, Arduino IDE 1.6.2 will not be installed unless explicitly specified in the version arguments."
211211
fi
212212
fi
213-
local -r ARDUINO_CI_SCRIPT_FULL_IDE_VERSION_LIST_ARRAY="${ARDUINO_CI_SCRIPT_IDE_VERSION_LIST_ARRAY_DECLARATION}'(\"$(git ls-remote --quiet --tags --refs | grep --invert-match --regexp='refs/tags/1\.0' --regexp='refs/tags/1\.5$' --regexp='refs/tags/1\.5\.1$' --regexp='refs/tags/1\.5\.4-r2$' --regexp='refs/tags/1\.5\.5-r2$' --regexp='refs/tags/1\.5\.7-macosx-java7$' --regexp='refs/tags/1\.5\.8-macosx-java7$' ${IDEversion162regex} --regexp='refs/tags/1\.6\.5-r2$' --regexp='refs/tags/1\.6\.5-r3$' | grep --regexp='refs/tags/[0-9]\+\.[0-9]\+\.[0-9]\+\(\(-.*$\)\|$\)' | cut --delimiter='/' --fields=3 | sort --version-sort | sed ':a;N;$!ba;s/\n/\" \"/g')\")'"
213+
214+
# Arduino IDE tag blacklist:
215+
# <1.5.2: no CLI (https://github.com/arduino/Arduino/blob/master/build/shared/manpage.adoc#history)
216+
# 1.5.4-r2: Not available for download
217+
# 1.5.5-r2: Not available for download
218+
# 1.5.7-macosx-java7: Not available for download
219+
# 1.5.8-macosx-java7: Not available for download
220+
# 1.6.2: has the nasty behavior of moving the included hardware cores to the .arduino15 folder, causing those versions to be used for all builds after Arduino IDE 1.6.2 is used. For that reason, 1.6.2 will only be installed if explicitly specified in the install_ide version arguments
221+
# 1.6.5-r2: Not available for download
222+
# 1.6.5-r3: Not available for download
223+
# 1.6.5-r2: Not available for download
224+
# 1.6.5-r3: Not available for download
225+
# 1.8.11-ms-store-1: Not available for download
226+
local -r ARDUINO_CI_SCRIPT_FULL_IDE_VERSION_LIST_ARRAY="${ARDUINO_CI_SCRIPT_IDE_VERSION_LIST_ARRAY_DECLARATION}'(\"$(git ls-remote --quiet --tags --refs | grep --invert-match --regexp='refs/tags/1\.0' --regexp='refs/tags/1\.5$' --regexp='refs/tags/1\.5\.1$' --regexp='refs/tags/1\.5\.4-r2$' --regexp='refs/tags/1\.5\.5-r2$' --regexp='refs/tags/1\.5\.7-macosx-java7$' --regexp='refs/tags/1\.5\.8-macosx-java7$' ${IDEversion162regex} --regexp='refs/tags/1\.6\.5-r2$' --regexp='refs/tags/1\.6\.5-r3$' --regexp='refs/tags/1\.8\.11-ms-store-1$' | grep --regexp='refs/tags/[0-9]\+\.[0-9]\+\.[0-9]\+\(\(-.*$\)\|$\)' | cut --delimiter='/' --fields=3 | sort --version-sort | sed ':a;N;$!ba;s/\n/\" \"/g')\")'"
214227
cd ..
215228
# Remove the temporary repo
216229
rm Arduino --recursive --force

0 commit comments

Comments
 (0)