address review comments

egegunes · egegunes · commit b0cae122a391 · 2023-06-14T11:23:10.000+03:00
diff --git a/pkg/apis/pxc/v1/pxc_types.go b/pkg/apis/pxc/v1/pxc_types.go
@@ -819,7 +819,7 @@ func (cr *PerconaXtraDBCluster) CheckNSetDefaults(serverVersion *version.ServerV
 			c.ProxySQL.ImagePullPolicy = corev1.PullAlways
 		}
 
-		if cr.CompareVersionWith("1.12.0") >= 0 && len(c.ProxySQL.PXCHandler) == 0 {
+		if cr.CompareVersionWith("1.13.0") >= 0 && len(c.ProxySQL.PXCHandler) == 0 {
 			c.ProxySQL.PXCHandler = "internal"
 		}
 
diff --git a/pkg/pxc/app/statefulset/proxysql.go b/pkg/pxc/app/statefulset/proxysql.go
@@ -147,7 +147,7 @@ func (c *Proxy) AppContainer(spec *api.PodSpec, secrets string, cr *api.PerconaX
 		}
 	}
 
-	if cr.CompareVersionWith("1.12.0") >= 0 {
+	if cr.CompareVersionWith("1.13.0") >= 0 {
 		appc.Env = append(appc.Env, corev1.EnvVar{
 			Name:  "PXC_HANDLER",
 			Value: cr.Spec.ProxySQL.PXCHandler,
@@ -244,7 +244,7 @@ func (c *Proxy) SidecarContainers(spec *api.PodSpec, secrets string, cr *api.Per
 		},
 	}
 
-	if cr.CompareVersionWith("1.12.0") >= 0 {
+	if cr.CompareVersionWith("1.13.0") >= 0 {
 		pxcMonit.Env = append(pxcMonit.Env, corev1.EnvVar{
 			Name:  "PXC_HANDLER",
 			Value: cr.Spec.ProxySQL.PXCHandler,

Original file line number	Diff line number	Diff line change
`@@ -819,7 +819,7 @@ func (cr PerconaXtraDBCluster) CheckNSetDefaults(serverVersion version.ServerV`
`819`	`819`	`c.ProxySQL.ImagePullPolicy = corev1.PullAlways`
`820`	`820`	`}`
`821`	`821`
`822`		`- if cr.CompareVersionWith("1.12.0") >= 0 && len(c.ProxySQL.PXCHandler) == 0 {`
	`822`	`+ if cr.CompareVersionWith("1.13.0") >= 0 && len(c.ProxySQL.PXCHandler) == 0 {`
`823`	`823`	`c.ProxySQL.PXCHandler = "internal"`
`824`	`824`	`}`
`825`	`825`
Original file line number	Diff line number	Diff line change
`@@ -147,7 +147,7 @@ func (c Proxy) AppContainer(spec api.PodSpec, secrets string, cr *api.PerconaX`
`147`	`147`	`}`
`148`	`148`	`}`
`149`	`149`
`150`		`- if cr.CompareVersionWith("1.12.0") >= 0 {`
	`150`	`+ if cr.CompareVersionWith("1.13.0") >= 0 {`
`151`	`151`	`appc.Env = append(appc.Env, corev1.EnvVar{`
`152`	`152`	`Name: "PXC_HANDLER",`
`153`	`153`	`Value: cr.Spec.ProxySQL.PXCHandler,`
`@@ -244,7 +244,7 @@ func (c Proxy) SidecarContainers(spec api.PodSpec, secrets string, cr *api.Per`
`244`	`244`	`},`
`245`	`245`	`}`
`246`	`246`
`247`		`- if cr.CompareVersionWith("1.12.0") >= 0 {`
	`247`	`+ if cr.CompareVersionWith("1.13.0") >= 0 {`
`248`	`248`	`pxcMonit.Env = append(pxcMonit.Env, corev1.EnvVar{`
`249`	`249`	`Name: "PXC_HANDLER",`
`250`	`250`	`Value: cr.Spec.ProxySQL.PXCHandler,`