-
Notifications
You must be signed in to change notification settings - Fork 202
K8SPXC-1686: delete job and its pods if runningDeadlineSeconds has been exceeded #2270
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mayank Shah <[email protected]>
gkech
reviewed
Nov 26, 2025
Signed-off-by: Mayank Shah <[email protected]>
egegunes
reviewed
Nov 27, 2025
Signed-off-by: Mayank Shah <[email protected]>
egegunes
previously approved these changes
Nov 27, 2025
Signed-off-by: Mayank Shah <[email protected]>
egegunes
approved these changes
Nov 28, 2025
gkech
approved these changes
Nov 28, 2025
Collaborator
commit: 21635d9 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CHANGE DESCRIPTION
Problem:
Backup job pods can remain in the cluster after
runningDeadlineSecondshas exceeded. There is a chance that eventually the pods start running and a backup takes place (which would be unexpected since we marked the backup hasfailed)Cause:
We leave the job behind after marking the backup as
failedSolution:
Delete the job after backup has failed due to
runningDeadlineSecondsexceeded.CHECKLIST
Jira
Needs Doc) and QA (Needs QA)?Tests
compare/*-oc.yml)?Config/Logging/Testability