PMM-14340 Add Valkey dashboards and corresponding tests #1018
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds comprehensive end-to-end (E2E) test coverage for Valkey dashboards in the monitoring system. It introduces new test scenarios that verify the presence and correctness of metrics across all Valkey dashboards, and enhances dashboard page support for Valkey. The changes also introduce support for Valkey in service type constants and improve the metric locator utility to handle dynamic metric names.
Valkey Dashboard E2E Test Coverage:
verifyValkeyDashboards_test.jswith scenarios that open each Valkey dashboard (Overview, Clients, Cluster Details, Command Detail, Load, Memory, Network, Persistence Details, Replication, Slowlog) and verify expected metrics and data presence. The test suite dynamically resolves the Valkey cluster name and uses it for dashboard URLs.Dashboard Page Enhancements:
dashboardPage.jsfor use in tests, including importing and exporting each dashboard's configuration. [1] [2]graphsLocatorPartialMatchfunction to support wildcard (*) matching in metric names, allowing for flexible and robust metric verification in dashboards with dynamic panel IDs.Valkey Dashboard Page Objects:
valkeyOverviewDashboard.jsvalkeyClientsDashboard.jsvalkeyClusterDetailsDashboard.jsvalkeyCommandDetailDashboard.jsvalkeyLoadDashboard.jsvalkeyMemoryDashboard.jsvalkeyNetworkDashboard.jsvalkeyPersistenceDetailsDashboard.jsvalkeyReplicationDashboard.jsvalkeySlowlogDashboard.jsConstants Update:
VALKEYentry to theSERVICE_TYPEconstants, enabling the tests and utilities to recognize Valkey as a supported service type.