Skip to content

Conversation

@travagliad
Copy link

This pull request adds comprehensive end-to-end (E2E) test coverage for Valkey dashboards in the monitoring system. It introduces new test scenarios that verify the presence and correctness of metrics across all Valkey dashboards, and enhances dashboard page support for Valkey. The changes also introduce support for Valkey in service type constants and improve the metric locator utility to handle dynamic metric names.

Valkey Dashboard E2E Test Coverage:

  • Added a new test suite verifyValkeyDashboards_test.js with scenarios that open each Valkey dashboard (Overview, Clients, Cluster Details, Command Detail, Load, Memory, Network, Persistence Details, Replication, Slowlog) and verify expected metrics and data presence. The test suite dynamically resolves the Valkey cluster name and uses it for dashboard URLs.

Dashboard Page Enhancements:

  • Registered all Valkey dashboard page objects in dashboardPage.js for use in tests, including importing and exporting each dashboard's configuration. [1] [2]
  • Improved the graphsLocatorPartialMatch function to support wildcard (*) matching in metric names, allowing for flexible and robust metric verification in dashboards with dynamic panel IDs.

Valkey Dashboard Page Objects:

  • Introduced new page object files for each Valkey dashboard, each specifying the dashboard URL and the list of metrics to verify:
    • valkeyOverviewDashboard.js
    • valkeyClientsDashboard.js
    • valkeyClusterDetailsDashboard.js
    • valkeyCommandDetailDashboard.js
    • valkeyLoadDashboard.js
    • valkeyMemoryDashboard.js
    • valkeyNetworkDashboard.js
    • valkeyPersistenceDetailsDashboard.js
    • valkeyReplicationDashboard.js
    • valkeySlowlogDashboard.js

Constants Update:

  • Added a new VALKEY entry to the SERVICE_TYPE constants, enabling the tests and utilities to recognize Valkey as a supported service type.

@travagliad travagliad requested a review from yurkovychv November 4, 2025 11:36
@travagliad travagliad merged commit 0ab4809 into v3 Nov 5, 2025
21 of 26 checks passed
@travagliad travagliad deleted the PMM-14340 branch November 5, 2025 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants