more fixes

Author: peterbe

dev-requirements.txt

@@ -4,9 +4,9 @@
 therapist==1.6.0 \
     --hash=sha256:ba7bebe4df1ee7c78b420b5894824ce8150868eab8819e8a4a510feefc0e2884 \
     --hash=sha256:e29c8c07676215093318e7b8aadc6c59784a1d9877eff77ffce20c9d63770a24
-black==18.9b0 \
-    --hash=sha256:817243426042db1d36617910df579a54f1afd659adb96fc5032fcf4b36209739 \
-    --hash=sha256:e030a9a28f542debc08acceb273f228ac422798e5215ba2a791a6ddeaaca22a5
-flake8==3.6.0 \
-    --hash=sha256:c01f8a3963b3571a8e6bd7a4063359aff90749e160778e03817cd9b71c9e07d2 \
-    --hash=sha256:6a35f5b8761f45c5513e3405f110a86bea57982c3b75b766ce7b65217abe1670
+black==19.3b0 \
+    --hash=sha256:09a9dcb7c46ed496a9850b76e4e825d6049ecd38b611f1224857a79bd985a8cf \
+    --hash=sha256:68950ffd4d9169716bcb8719a56c07a2f4485354fec061cdd5910aa07369731c
+flake8==3.7.7 \
+    --hash=sha256:859996073f341f2670741b51ec1e67a01da142831aa1fdc6242dbf88dffbe661 \
+    --hash=sha256:a796a115208f5c03b18f332f7c11729812c8c3ded6c46319c59b53efd3819da8

package.json

@@ -6,10 +6,10 @@
     "bootstrap": "4.3.1",
     "classnames": "2.2.6",
     "ky": "0.9.0",
-    "react": "16.8.3",
-    "react-dom": "16.8.3",
-    "react-router-dom": "4.3.1",
-    "react-scripts": "2.1.5",
+    "react": "16.8.6",
+    "react-dom": "16.8.6",
+    "react-router-dom": "5.0.0",
+    "react-scripts": "2.1.8",
     "react-timeago": "4.4.0",
     "reactstrap": "7.1.0"
   },
@@ -32,6 +32,6 @@
   ],
   "devDependencies": {
     "prettier": "1.16.4",
-    "source-map-explorer": "1.7.0"
+    "source-map-explorer": "1.8.0"
   }
 }

requirements-constraints.txt

@@ -114,13 +114,15 @@ toml==0.10.0 \
 attrs==18.2.0 \
     --hash=sha256:ca4be454458f9dec299268d472aaa5a11f67a4ff70093396e1ceae9c76cf4bbb \
     --hash=sha256:10cbf6e27dbce8c30807caf056c8eb50917e0eaafe86347671b57254006c3e69
-pyflakes==2.0.0 \
-    --hash=sha256:f661252913bc1dbe7fcfcbf0af0db3f42ab65aabd1a6ca68fe5d466bace94dae \
-    --hash=sha256:9a7662ec724d0120012f6e29d6248ae3727d821bba522a0e6b356eff19126a49
+pyflakes==2.1.1 \
+    --hash=sha256:17dbeb2e3f4d772725c777fabc446d5634d1038f234e77343108ce445ea69ce0 \
+    --hash=sha256:d976835886f8c5b31d47970ed689944a0262b5f3afa00a5a7b4dc81e5449f8a2
 mccabe==0.6.1 \
     --hash=sha256:ab8a6258860da4b6677da4bd2fe5dc2c659cff31b3ee4f7f5d64e79735b80d42 \
     --hash=sha256:dd8d182285a0fe56bace7f45b5e7d1a6ebcbf524e8f3bd87eb0f125271b8831f
-pycodestyle==2.4.0 \
-    --hash=sha256:cbc619d09254895b0d12c2c691e237b2e91e9b2ecf5e84c26b35400f93dcfb83 \
-    --hash=sha256:74abc4e221d393ea5ce1f129ea6903209940c1ecd29e002e8c6933c2b21026e0 \
-    --hash=sha256:cbfca99bd594a10f674d0cd97a3d802a1fdef635d4361e1a2658de47ed261e3a
+pycodestyle==2.5.0 \
+    --hash=sha256:95a2219d12372f05704562a14ec30bc76b05a5b297b21a5dfe3f6fac3491ae56 \
+    --hash=sha256:e40a936c9a450ad81df37f549d676d127b1b66000a6c500caa2b085bc0ca976c
+entrypoints==0.3 \
+    --hash=sha256:589f874b313739ad35be6e0cd7efde2a4e9b6fea91edcc34e58ecbb8dbe56d19 \
+    --hash=sha256:c70dd71abe5a8c85e55e12c19bd91ccfeec11a6e99044204511f9ed547d48451

src/DeployPage.js

@@ -11,6 +11,12 @@ import { EllipsisLoading } from './Common';
 
 const BORS_LOGIN = 'bors[bot]';
 
+function makeTagAbsoluteUrl(owner, repo, tag) {
+  return `https://github.com/${owner}/${repo}/releases/tag/${encodeURIComponent(
+    tag
+  )}`;
+}
+
 class DeployPage extends React.Component {
   static propsTypes = {
     shortCode: PropTypes.string.isRequired
@@ -183,6 +189,8 @@ class DeployPage extends React.Component {
               commits={commits}
               tags={tags}
               code={code}
+              owner={owner}
+              repo={repo}
             />
             <RepoSummary
               deployInfo={deployInfo}
@@ -207,7 +215,9 @@ class DeployTable extends React.Component {
     ).isRequired,
     commits: PropTypes.arrayOf(PropTypes.shape({})).isRequired,
     tags: PropTypes.object.isRequired,
-    code: PropTypes.string.isRequired
+    code: PropTypes.string.isRequired,
+    owner: PropTypes.string.isRequired,
+    repo: PropTypes.string.isRequired
   };
   static prefBorsModeCacheKey = 'pref-bors-mode';
 
@@ -241,8 +251,9 @@ class DeployTable extends React.Component {
   };
 
   render() {
-    const { deployInfo, commits, tags, code } = this.props;
+    const { deployInfo, commits, tags, owner, repo, code } = this.props;
     const shortUrl = `/s/${code}`;
+
     const { borsMode } = this.state;
 
     let hasBors = false;
@@ -285,6 +296,8 @@ class DeployTable extends React.Component {
             tag={tags[commit.sha]}
             users={usersByLogin}
             borsMode={borsMode}
+            owner={owner}
+            repo={repo}
           />
           {deployInfo.map(deploy => (
             <td
@@ -358,6 +371,8 @@ class CommitDetails extends React.Component {
       html_url: PropTypes.string.isRequired
     }),
     html_url: PropTypes.string.isRequired,
+    owner: PropTypes.string.isRequired,
+    repo: PropTypes.string.isRequired,
     tag: PropTypes.any
   };
 
@@ -403,7 +418,7 @@ class CommitDetails extends React.Component {
   }
 
   render() {
-    let { commit, author, tag, html_url, borsMode } = this.props;
+    let { commit, author, tag, html_url, borsMode, owner, repo } = this.props;
 
     let involvedUsers = [author];
 
@@ -427,9 +442,13 @@ class CommitDetails extends React.Component {
           {title}
         </a>
         {tag && (
-          <span className="badge badge-pill badge-info" title={`Tag: ${tag}`}>
+          <a
+            href={makeTagAbsoluteUrl(owner, repo, tag)}
+            className="badge badge-pill badge-info"
+            title={`Tag: ${tag}`}
+          >
             {tag}
-          </span>
+          </a>
         )}
         {commit.date}
         <TimeAgo
@@ -468,6 +487,15 @@ function UserAvatars({ users }) {
 }
 
 class RepoSummary extends React.Component {
+  static propTypes = {
+    deployInfo: PropTypes.arrayOf(
+      PropTypes.shape({ name: PropTypes.string.isRequired })
+    ).isRequired,
+    owner: PropTypes.string.isRequired,
+    repo: PropTypes.string.isRequired,
+    tags: PropTypes.object.isRequired
+  };
+
   render() {
     const { deployInfo, tags, owner, repo } = this.props;
 
@@ -546,9 +574,13 @@ class ShaLink extends React.Component {
           {sha.slice(0, 7)}
         </a>
         {tag && (
-          <span className="badge badge-pill badge-info" title={`Tag: ${tag}`}>
+          <a
+            href={makeTagAbsoluteUrl(owner, repo, tag)}
+            className="badge badge-pill badge-info"
+            title={`Tag: ${tag}`}
+          >
             {tag}
-          </span>
+          </a>
         )}
       </>
     );