Skip to content

Commit deb360f

Browse files
author
Peter Bengtsson
authored
simplify UserAvatar component (#69)
1 parent 1cfe31d commit deb360f

File tree

1 file changed

+25
-32
lines changed

1 file changed

+25
-32
lines changed

src/DeployPage.js

Lines changed: 25 additions & 32 deletions
Original file line numberDiff line numberDiff line change
@@ -391,7 +391,7 @@ class CommitDetails extends React.Component {
391391

392392
return (
393393
<td>
394-
<UserAvatar users={involvedUsers} />
394+
<UserAvatars users={involvedUsers} />
395395
<a className="commit" href={html_url} title={commit.message}>
396396
{title}
397397
</a>
@@ -410,37 +410,30 @@ class CommitDetails extends React.Component {
410410
}
411411
}
412412

413-
class UserAvatar extends React.Component {
414-
render() {
415-
const { users } = this.props;
416-
417-
if (users.every(u => !u)) {
418-
}
419-
420-
return (
421-
<div className="user-avatar-group">
422-
{users.map(user => {
423-
if (!user) {
424-
return (
425-
<span className="user-avatar unknown-user" title="Unknown User" />
426-
);
427-
} else {
428-
const { html_url, login, avatar_url } = user;
429-
return (
430-
<a
431-
key={login}
432-
className="user-avatar"
433-
href={html_url}
434-
title={login}
435-
>
436-
<img src={avatar_url} alt={login} />
437-
</a>
438-
);
439-
}
440-
})}
441-
</div>
442-
);
443-
}
413+
function UserAvatars({ users }) {
414+
return (
415+
<div className="user-avatar-group">
416+
{users.map(user => {
417+
if (!user) {
418+
return (
419+
<span className="user-avatar unknown-user" title="Unknown User" />
420+
);
421+
} else {
422+
const { html_url, login, avatar_url } = user;
423+
return (
424+
<a
425+
key={login}
426+
className="user-avatar"
427+
href={html_url}
428+
title={login}
429+
>
430+
<img src={avatar_url} alt={login} />
431+
</a>
432+
);
433+
}
434+
})}
435+
</div>
436+
);
444437
}
445438

446439
class RepoSummary extends React.Component {

0 commit comments

Comments
 (0)