Skip to content

Commit 2069fa9

Browse files
committed
Clarify that URLs can be up to 237 characters in length
1 parent df9a358 commit 2069fa9

File tree

3 files changed

+3
-2
lines changed

3 files changed

+3
-2
lines changed

.gitignore

+1
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
11
pkg/*
22
*.gem
33
.bundle
4+
.DS_Store

README.md

+1-1
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22

33
*webloc* is a Ruby library that can read from and write to <tt>.webloc</tt> files as used on macOS. These are a variant of 'plist' format files, specifically used for storing links to URLs.
44

5-
It works on Ruby 2.7 and up, including Ruby 3.x, and supports URLs of up to 255 characters in length.
5+
It works on Ruby 2.7 and up, including Ruby 3.x, and supports URLs of up to 237 characters in length (but am currently working on extending this).
66

77
## Installation
88

test/webloc_test.rb

+1-1
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ def test_webloc_generates_valid_data
2525
end
2626

2727
def test_webloc_can_handle_long_urls
28-
url = "http://example.com/this-is-a-very-long-url-indeed-it-should-easily-go-over-110-characters-for-our-testing-purposes"
28+
url = "http://example.com/this-is-a-very-long-url-indeed-it-should-easily-go-over-110-characters-for-our-testing-purposes-lets-make-it-a-big-longer-to-get-up-to-the-two-hundred-and-fifty-five-limit-just-a-little-bit-further-to-go-nearly-there-1"
2929
assert_nothing_raised { Webloc.new(url).data }
3030
end
3131

0 commit comments

Comments
 (0)