Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add ethereum-rlp as a dependency and/or report missing dependencies (?) #7

Open
danceratopz opened this issue Jan 16, 2025 · 0 comments

Comments

@danceratopz
Copy link
Contributor

danceratopz commented Jan 16, 2025

ethereum/execution-specs#1034 refactored execution-specs to use ethereum-rlp. This triggered a somewhat unexpected issue in EEST.

  1. EEST's eels_resolutions.json had incorrect entries for ethereum/paris (it used the key Paris whereas it should of been Merge) which resulted in EEST using execution-specs' latest master to fill tests for Paris (instead of the intended pinned version).
  2. This then failed because ethereum-rlp was missing as a dependency.

More info in: ethereum/execution-spec-tests#1083 (comment)

I'm glad we found this error in EEST's eels_resolution.json file sooner rather than later. But, as the eels resolver isn't currently aware of the dependencies required by a branch (and couldn't install them anyway), should we add ethereum-rlp as a dependency to the resolver to prevent this being an issue for other potential users in the future?

What would be amazing, but perhaps too much effort for this edge case, would be that the resolver checks the dependencies for the EELS implementations it retrieves and fails if they're not available in the current environment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant