You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
EEST's eels_resolutions.json had incorrect entries for ethereum/paris (it used the key Paris whereas it should of been Merge) which resulted in EEST using execution-specs' latest master to fill tests for Paris (instead of the intended pinned version).
This then failed because ethereum-rlp was missing as a dependency.
I'm glad we found this error in EEST's eels_resolution.json file sooner rather than later. But, as the eels resolver isn't currently aware of the dependencies required by a branch (and couldn't install them anyway), should we add ethereum-rlp as a dependency to the resolver to prevent this being an issue for other potential users in the future?
What would be amazing, but perhaps too much effort for this edge case, would be that the resolver checks the dependencies for the EELS implementations it retrieves and fails if they're not available in the current environment.
The text was updated successfully, but these errors were encountered:
ethereum/execution-specs#1034 refactored execution-specs to use ethereum-rlp. This triggered a somewhat unexpected issue in EEST.
eels_resolutions.json
had incorrect entries forethereum/paris
(it used the keyParis
whereas it should of beenMerge
) which resulted in EEST using execution-specs' latest master to fill tests for Paris (instead of the intended pinned version).ethereum-rlp
was missing as a dependency.More info in: ethereum/execution-spec-tests#1083 (comment)
I'm glad we found this error in EEST's eels_resolution.json file sooner rather than later. But, as the eels resolver isn't currently aware of the dependencies required by a branch (and couldn't install them anyway), should we add ethereum-rlp as a dependency to the resolver to prevent this being an issue for other potential users in the future?
What would be amazing, but perhaps too much effort for this edge case, would be that the resolver checks the dependencies for the EELS implementations it retrieves and fails if they're not available in the current environment.
The text was updated successfully, but these errors were encountered: