Compiler is too lax #19895

Activity

1. Ducasse

   added

   Type: Bug

   on Jul 23, 2026
2. Ducasse commented on Jul 23, 2026

   

   Ducasse

   on Jul 23, 2026

   MemberAuthor

   More actions

   I would expect the following to fail.

   OpalCompiler new
   				source: 'method: self ';
   				permitFaulty: false;
   				compileOrFail.
   
3. Ducasse commented on Jul 23, 2026

   

   Ducasse

   on Jul 23, 2026

   MemberAuthor

   More actions

   Looks like we can improve the semantic analyser to add notice when temps and args use reserved words.

   declareVariableNode: aVariableNode as: anOCTempVariable
   	| name var shadowing |
   	name := aVariableNode name.
   	"check if another variable with same name is visible"
   	shadowing := scope lookupVar: name.
   	var := scope addTemp: anOCTempVariable.
   	aVariableNode binding: var.
   	(shadowing isNotNil and: [ shadowing allowsShadowing not]) ifTrue: [self shadowing: shadowing withVariable: aVariableNode].
   	^ var
   
   declareTemporaryNode: aVariableNode
   	^self declareVariableNode: aVariableNode as: (TemporaryVariable named: aVariableNode name)
   
4. Ducasse commented on Jul 23, 2026

   

   Ducasse

   on Jul 23, 2026

   MemberAuthor

   More actions

   same with blocks arg and temps.

   OpalCompiler new
   				source: 'method  ^ [ :self |
   					|self |
   					self := 33 ]';
   				permitFaulty: false;
   				compileOrFail.