Skip to content

Commit 5e174d5

Browse files
committed
Cleaning GistPresenter and some other test
1 parent d9a4a83 commit 5e174d5

2 files changed

Lines changed: 12 additions & 21 deletions

File tree

Iceberg-Playground-Plugin-Gist/IcePublishGistPresenter.class.st

Lines changed: 7 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -21,17 +21,11 @@ Class {
2121
}
2222

2323
{ #category : 'accessing' }
24-
IcePublishGistPresenter class >> initialExtent [
24+
IcePublishGistPresenter class >> defaultPreferredExtent [
2525

2626
^ 600@400
2727
]
2828

29-
{ #category : 'accessing' }
30-
IcePublishGistPresenter class >> windowTitle [
31-
32-
^ 'Publish Gist'
33-
]
34-
3529
{ #category : 'accessing' }
3630
IcePublishGistPresenter >> content: aString [
3731

@@ -88,14 +82,6 @@ IcePublishGistPresenter >> initializePresenters [
8882
beForScripting
8983
]
9084

91-
{ #category : 'initialization' }
92-
IcePublishGistPresenter >> initializeWindow: aWindowPresenter [
93-
94-
aWindowPresenter
95-
title: self class windowTitle;
96-
initialExtent: self class initialExtent.
97-
]
98-
9985
{ #category : 'actions' }
10086
IcePublishGistPresenter >> publishThen: aBlock [
10187
| description public jsonResult |
@@ -143,3 +129,9 @@ IcePublishGistPresenter >> whenPublishedDo: aBlock [
143129

144130
publishedAction := aBlock
145131
]
132+
133+
{ #category : 'events' }
134+
IcePublishGistPresenter >> windowTitle [
135+
136+
^ 'Publish Gist'
137+
]

Iceberg-UI-Tests/IceTipPresenterMetaTest.class.st

Lines changed: 5 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -96,19 +96,18 @@ IceTipPresenterMetaTest >> testDefaultSpecDoesntUsePragma [
9696
{ #category : 'tests' }
9797
IceTipPresenterMetaTest >> testDoNotImplementDiscouragedSelectors [
9898

99-
"Either instance or class-side, the old #title is named #titleForWindow in inst-side."
100-
self assertEmpty: (self presenterClassesDefining: #title isMeta: true).
101-
self assertEmpty: (self presenterClassesDefining: #title isMeta: false).
99+
"Either instance the old #title is named #windowTitle in inst-side."
100+
self assertEmpty: (self presenterClassesDefining: #windowTitle isMeta: true).
102101

103-
"The #icon is called #iconForWindow in IceTip UI."
104-
self assertEmpty: (self presenterClassesDefining: #icon isMeta: true).
102+
"The #icon is called #windowIcon in IceTip UI."
103+
self assertEmpty: (self presenterClassesDefining: #windowIcon isMeta: true).
105104

106105
"These methods are not yet deprecated via pragma, but discouraged in Spec2."
107106
self assertEmpty: (self presenterClassesDefining: #initialExtent isMeta: false).
108107
self assertEmpty: (self presenterClassesDefining: #initializeWidgets isMeta: false).
109108
self assertEmpty: (self presenterClassesDefining: #initializePresenter isMeta: false).
110109

111-
self assertEmpty: (self presenterClassesDefining: #windowIcon isMeta: false).
110+
112111

113112

114113
]

0 commit comments

Comments
 (0)