Shouldn't core_components.ex have some unit tests?

[jdmarshall]

There's a lot of complexity already in here, especially once you get into the livestream bits and these really should have tests. Especially if someone were inclined to create a PR to add more features or new components

Background:

I'm trying to write ul and ol components that work a bit like the table component.

Initially I couldn't get updates to work properly and had to fiddle a bit to get things to work right. I realized I probably should have written some tests for this so I get it right, and I couldn't work out how to test livestream support. So I figured I'd look at the table tests and test them the same way. Only... I could not find any tests associated with the core_components.ex file, either in the directory structure or in the commit history.

It would also be good to have more examples of how to write good tests for your own components, other than the tests generated in the templates which are a bit light.

[chrismccord]

I’m not convinced we need unit level tests here and the tests our code generators generate naturally covers core component usage. You are of course welcome to add more in your app. Thanks!

[jdmarshall]

How do you propose to avoid breaking changes from contributors if there are no tests to assert existing functionality?

[chrismccord]

See integrationt_test/