The DecisionExecutor has been refactored to use IDecisionReasoningEngine for decision logic and IMediator for persistence. However, there are pending tasks to fully complete the integration and testing.
-
Fix Build Errors in Shared Project:
- There are missing XML comments in
CognitiveMesh.Shared(NodeLabels.cs) causing build failures (warnings treated as errors). - Resolve these to ensure a clean build.
- There are missing XML comments in
-
Verify Tests:
- Once the build is fixed, run
dotnet test tests/AgencyLayer/DecisionExecution/DecisionExecution.Tests.csproj. - Ensure
DecisionExecutorTestsandConclAIveReasoningAdapterTestspass.
- Once the build is fixed, run
-
Persistence Implementation:
- The
DecisionPersistenceHandlerstores the result in the Knowledge Graph. - Verify the graph schema/structure aligns with other components (e.g.,
NodeLabels).
- The
-
Integration with ActionPlanner:
- Currently,
DecisionExecutorjust returns a result and persists it. - Consider if it should also trigger actions via
ActionPlannerdirectly or if another handler should listen toDecisionMadeNotificationto trigger actions.
- Currently,
-
Reasoning Recipe Selection:
- The
ConclAIveReasoningAdaptercurrently defaults tonull(auto) for recipe type unless specified in metadata. - Refine the logic to select recipes based on
DecisionType.
- The
- Modified Files:
src/AgencyLayer/DecisionExecution/DecisionExecutor.cssrc/AgencyLayer/DecisionExecution/DecisionExecution.csprojsrc/AgencyLayer/DecisionExecution/IDecisionReasoningEngine.cs(New)src/AgencyLayer/DecisionExecution/Adapters/ConclAIveReasoningAdapter.cs(New)src/AgencyLayer/DecisionExecution/Events/DecisionMadeNotification.cs(New)src/AgencyLayer/DecisionExecution/Handlers/DecisionPersistenceHandler.cs(New)tests/AgencyLayer/DecisionExecution/DecisionExecution.Tests.csproj(New)tests/AgencyLayer/DecisionExecution/DecisionExecutorTests.cs(New)