feat: Add comprehensive unit tests for Albert API integration

- Add unit tests for EmbeddingsModelClient and GPTModelClient
- Update PlatformFactory to require explicit API version in URL
- Replace webmozart/assert with plain PHP exception handling
- Use JsonMockResponse in tests for better consistency
- Fix URL handling to ensure proper slash between version and endpoint
- Apply rector and code style fixes

Author: OskarStark

examples/albert/chat.php

@@ -16,7 +16,7 @@
 }
 
 if (empty($_ENV['ALBERT_API_URL'])) {
-    echo 'Please set the ALBERT_API_URL environment variable (e.g., https://your-albert-instance.com).'.\PHP_EOL;
+    echo 'Please set the ALBERT_API_URL environment variable (e.g., https://your-albert-instance.com/v1).'.\PHP_EOL;
     exit(1);
 }
 

src/Platform/Bridge/Albert/EmbeddingsModelClient.php

@@ -15,8 +15,7 @@
 {
     public function __construct(
         private HttpClientInterface $httpClient,
-        #[\SensitiveParameter]
-        private string $apiKey,
+        #[\SensitiveParameter] private string $apiKey,
         private string $baseUrl,
     ) {
         if ('' === $apiKey) {

src/Platform/Bridge/Albert/PlatformFactory.php

@@ -25,12 +25,10 @@ public static function create(
 
         $httpClient = $httpClient instanceof EventSourceHttpClient ? $httpClient : new EventSourceHttpClient($httpClient);
 
-        // The base URL should include the full path to the API endpoint
-        // Check if the URL already contains a version pattern (e.g., /v1, /v2, etc.)
+        // The base URL should include the full path to the API endpoint including version
         $baseUrl = rtrim($albertUrl, '/');
         if (!preg_match('/\/v\d+$/', $baseUrl)) {
-            // Default to v1 if no version is specified
-            $baseUrl .= '/v1';
+            throw new InvalidArgumentException('The Albert URL must include an API version (e.g., /v1, /v2).');
         }
         // Don't add trailing slash here - let the model clients handle it
 

tests/Platform/Bridge/Albert/PlatformFactoryTest.php

@@ -20,7 +20,7 @@ final class PlatformFactoryTest extends TestCase
     #[Test]
     public function createsPlatformWithCorrectBaseUrl(): void
     {
-        $platform = PlatformFactory::create('test-key', 'https://albert.example.com');
+        $platform = PlatformFactory::create('test-key', 'https://albert.example.com/v1');
 
         self::assertInstanceOf(Platform::class, $platform);
     }
@@ -36,8 +36,6 @@ public function handlesUrlsCorrectly(string $url): void
 
     public static function urlProvider(): \Iterator
     {
-        yield 'with trailing slash' => ['https://albert.example.com/'];
-        yield 'without trailing slash' => ['https://albert.example.com'];
         yield 'with v1 path' => ['https://albert.example.com/v1'];
         yield 'with v1 path and trailing slash' => ['https://albert.example.com/v1/'];
         yield 'with v2 path' => ['https://albert.example.com/v2'];
@@ -57,18 +55,19 @@ public function throwsExceptionForNonHttpsUrl(): void
     }
 
     #[Test]
-    #[DataProvider('invalidVersionUrlProvider')]
-    public function defaultsToV1ForInvalidVersionPatterns(string $url): void
+    #[DataProvider('urlsWithoutVersionProvider')]
+    public function throwsExceptionForUrlsWithoutVersion(string $url): void
     {
-        // This test verifies that URLs without proper version patterns
-        // will get /v1 appended by default
-        $platform = PlatformFactory::create('test-key', $url);
+        $this->expectException(InvalidArgumentException::class);
+        $this->expectExceptionMessage('The Albert URL must include an API version (e.g., /v1, /v2).');
 
-        self::assertInstanceOf(Platform::class, $platform);
+        PlatformFactory::create('test-key', $url);
     }
 
-    public static function invalidVersionUrlProvider(): \Iterator
+    public static function urlsWithoutVersionProvider(): \Iterator
     {
+        yield 'without version' => ['https://albert.example.com'];
+        yield 'with trailing slash only' => ['https://albert.example.com/'];
         yield 'with vx path' => ['https://albert.example.com/vx'];
         yield 'with version path' => ['https://albert.example.com/version'];
         yield 'with api path' => ['https://albert.example.com/api'];