Use package-specific exceptions instead of generic PHP exceptions

Author: OskarStark

src/Platform/Exception/LogicException.php

@@ -0,0 +1,9 @@
+<?php
+
+declare(strict_types=1);
+
+namespace PhpLlm\LlmChain\Platform\Exception;
+
+class LogicException extends \LogicException implements ExceptionInterface
+{
+}

src/Platform/Fabric/FabricInputProcessor.php

@@ -7,13 +7,13 @@
 use PhpLlm\FabricPattern\Pattern;
 use PhpLlm\LlmChain\Chain\Input;
 use PhpLlm\LlmChain\Chain\InputProcessorInterface;
+use PhpLlm\LlmChain\Platform\Exception\InvalidArgumentException;
+use PhpLlm\LlmChain\Platform\Exception\LogicException;
+use PhpLlm\LlmChain\Platform\Exception\RuntimeException;
 use PhpLlm\LlmChain\Platform\Message\SystemMessage;
 
 /**
  * Requires the "php-llm/fabric-pattern" package to be installed.
- *
- * This processor allows adding Fabric patterns through options:
- * - fabric_pattern: string - The pattern name to load
  */
 final readonly class FabricInputProcessor implements InputProcessorInterface
 {
@@ -27,27 +27,22 @@ public function processInput(Input $input): void
 
         $pattern = $options['fabric_pattern'];
         if (!\is_string($pattern)) {
-            throw new \InvalidArgumentException('The "fabric_pattern" option must be a string');
+            throw new InvalidArgumentException('The "fabric_pattern" option must be a string');
         }
 
-        // Check if there's already a system message
         if (null !== $input->messages->getSystemMessage()) {
-            throw new \LogicException('Cannot add Fabric pattern: MessageBag already contains a system message');
+            throw new LogicException('Cannot add Fabric pattern: MessageBag already contains a system message');
         }
 
-        // Check if fabric-pattern package is installed
         if (!class_exists(Pattern::class)) {
-            throw new \RuntimeException('Fabric patterns not found. Please install the "php-llm/fabric-pattern" package: composer require php-llm/fabric-pattern');
+            throw new RuntimeException('Fabric patterns not found. Please install the "php-llm/fabric-pattern" package: composer require php-llm/fabric-pattern');
         }
 
-        // Load the pattern and prepend as system message
         $content = (new Pattern())->load($pattern);
         $systemMessage = new SystemMessage($content);
 
-        // Prepend the system message
         $input->messages = $input->messages->prepend($systemMessage);
 
-        // Remove the fabric option from the chain options
         unset($options['fabric_pattern']);
         $input->setOptions($options);
     }

src/Platform/Message/Message.php

@@ -5,6 +5,7 @@
 namespace PhpLlm\LlmChain\Platform\Message;
 
 use PhpLlm\FabricPattern\Pattern;
+use PhpLlm\LlmChain\Platform\Exception\RuntimeException;
 use PhpLlm\LlmChain\Platform\Message\Content\ContentInterface;
 use PhpLlm\LlmChain\Platform\Message\Content\Text;
 use PhpLlm\LlmChain\Platform\Response\ToolCall;
@@ -38,7 +39,7 @@ public static function forSystem(\Stringable|string $content): SystemMessage
     public static function fabric(string $pattern): SystemMessage
     {
         if (!class_exists(Pattern::class)) {
-            throw new \RuntimeException('Fabric patterns not found. Please install the "php-llm/fabric-pattern" package: composer require php-llm/fabric-pattern');
+            throw new RuntimeException('Fabric patterns not found. Please install the "php-llm/fabric-pattern" package: composer require php-llm/fabric-pattern');
         }
 
         $content = (new Pattern())->load($pattern);

tests/Platform/Fabric/FabricInputProcessorTest.php

@@ -5,6 +5,9 @@
 namespace PhpLlm\LlmChain\Tests\Platform\Fabric;
 
 use PhpLlm\LlmChain\Chain\Input;
+use PhpLlm\LlmChain\Platform\Exception\InvalidArgumentException;
+use PhpLlm\LlmChain\Platform\Exception\LogicException;
+use PhpLlm\LlmChain\Platform\Exception\RuntimeException;
 use PhpLlm\LlmChain\Platform\Fabric\FabricInputProcessor;
 use PhpLlm\LlmChain\Platform\Message\MessageBag;
 use PhpLlm\LlmChain\Platform\Message\SystemMessage;
@@ -42,7 +45,7 @@ public function processInputWithInvalidPatternType(): void
         $model = new Model('test-model', []);
         $input = new Input($model, $messages, ['fabric_pattern' => 123]);
 
-        $this->expectException(\InvalidArgumentException::class);
+        $this->expectException(InvalidArgumentException::class);
         $this->expectExceptionMessage('The "fabric_pattern" option must be a string');
 
         $processor->processInput($input);
@@ -57,7 +60,7 @@ public function processInputThrowsExceptionWhenSystemMessageExists(): void
         $model = new Model('test-model', []);
         $input = new Input($model, $messages, ['fabric_pattern' => 'test_pattern']);
 
-        $this->expectException(\LogicException::class);
+        $this->expectException(LogicException::class);
         $this->expectExceptionMessage('Cannot add Fabric pattern: MessageBag already contains a system message');
 
         $processor->processInput($input);
@@ -72,7 +75,7 @@ public function processInputThrowsExceptionWhenPackageNotInstalled(): void
         $model = new Model('test-model', []);
         $input = new Input($model, $messages, ['fabric_pattern' => 'test_pattern']);
 
-        $this->expectException(\RuntimeException::class);
+        $this->expectException(RuntimeException::class);
         $this->expectExceptionMessage('Fabric patterns not found. Please install the "php-llm/fabric-pattern" package');
 
         $processor->processInput($input);

tests/Platform/Message/MessageFabricTest.php

@@ -4,6 +4,7 @@
 
 namespace PhpLlm\LlmChain\Tests\Platform\Message;
 
+use PhpLlm\LlmChain\Platform\Exception\RuntimeException;
 use PhpLlm\LlmChain\Platform\Message\Message;
 use PHPUnit\Framework\Attributes\CoversClass;
 use PHPUnit\Framework\Attributes\Small;
@@ -17,7 +18,7 @@ final class MessageFabricTest extends TestCase
     #[Test]
     public function fabricMethodThrowsExceptionWhenPackageNotInstalled(): void
     {
-        $this->expectException(\RuntimeException::class);
+        $this->expectException(RuntimeException::class);
         $this->expectExceptionMessage('Fabric patterns not found. Please install the "php-llm/fabric-pattern" package');
 
         Message::fabric('test_pattern');