diff --git a/UPGRADING.INTERNALS b/UPGRADING.INTERNALS index 56c7535158460..7c7f093e50cce 100644 --- a/UPGRADING.INTERNALS +++ b/UPGRADING.INTERNALS @@ -61,6 +61,10 @@ PHP 8.5 INTERNALS UPGRADE NOTES is still valid. This is useful when a GC cycle is collected and the database object can be destroyed prior to destroying the statement. +- ext/standard + . Added php_url_decode_ex() and php_raw_url_decode_ex() that unlike their + non-ex counterparts do not work in-place. + ======================== 4. OpCode changes ======================== diff --git a/ext/standard/url.c b/ext/standard/url.c index 7d564b510bc9f..5168d591a2a4c 100644 --- a/ext/standard/url.c +++ b/ext/standard/url.c @@ -411,21 +411,24 @@ PHP_FUNCTION(parse_url) } /* }}} */ +/* https://stackoverflow.com/questions/34365746/whats-the-fastest-way-to-convert-hex-to-integer-in-c */ +static unsigned int php_htoi_single(unsigned char x) +{ + ZEND_ASSERT((x >= 'a' && x <= 'f') || (x >= 'A' && x <= 'F') || (x >= '0' && x <= '9')); + return 9 * (x >> 6) + (x & 0xf); +} + /* {{{ php_htoi */ -static int php_htoi(char *s) +static int php_htoi(const char *s) { int value; - int c; + unsigned char c; c = ((unsigned char *)s)[0]; - if (isupper(c)) - c = tolower(c); - value = (c >= '0' && c <= '9' ? c - '0' : c - 'a' + 10) * 16; + value = php_htoi_single(c) * 16; c = ((unsigned char *)s)[1]; - if (isupper(c)) - c = tolower(c); - value += c >= '0' && c <= '9' ? c - '0' : c - 'a' + 10; + value += php_htoi_single(c); return (value); } @@ -571,28 +574,27 @@ PHP_FUNCTION(urldecode) Z_PARAM_STR(in_str) ZEND_PARSE_PARAMETERS_END(); - out_str = zend_string_init(ZSTR_VAL(in_str), ZSTR_LEN(in_str), 0); - ZSTR_LEN(out_str) = php_url_decode(ZSTR_VAL(out_str), ZSTR_LEN(out_str)); + out_str = zend_string_alloc(ZSTR_LEN(in_str), false); + ZSTR_LEN(out_str) = php_url_decode_ex(ZSTR_VAL(out_str), ZSTR_VAL(in_str), ZSTR_LEN(in_str)); RETURN_NEW_STR(out_str); } /* }}} */ -/* {{{ php_url_decode */ -PHPAPI size_t php_url_decode(char *str, size_t len) +PHPAPI size_t php_url_decode_ex(char *dest, const char *src, size_t src_len) { - char *dest = str; - char *data = str; + char *dest_start = dest; + const char *data = src; - while (len--) { + while (src_len--) { if (*data == '+') { *dest = ' '; } - else if (*data == '%' && len >= 2 && isxdigit((int) *(data + 1)) + else if (*data == '%' && src_len >= 2 && isxdigit((int) *(data + 1)) && isxdigit((int) *(data + 2))) { *dest = (char) php_htoi(data + 1); data += 2; - len -= 2; + src_len -= 2; } else { *dest = *data; } @@ -600,7 +602,13 @@ PHPAPI size_t php_url_decode(char *str, size_t len) dest++; } *dest = '\0'; - return dest - str; + return dest - dest_start; +} + +/* {{{ php_url_decode */ +PHPAPI size_t php_url_decode(char *str, size_t len) +{ + return php_url_decode_ex(str, str, len); } /* }}} */ @@ -633,25 +641,24 @@ PHP_FUNCTION(rawurldecode) Z_PARAM_STR(in_str) ZEND_PARSE_PARAMETERS_END(); - out_str = zend_string_init(ZSTR_VAL(in_str), ZSTR_LEN(in_str), 0); - ZSTR_LEN(out_str) = php_raw_url_decode(ZSTR_VAL(out_str), ZSTR_LEN(out_str)); + out_str = zend_string_alloc(ZSTR_LEN(in_str), false); + ZSTR_LEN(out_str) = php_raw_url_decode_ex(ZSTR_VAL(out_str), ZSTR_VAL(in_str), ZSTR_LEN(in_str)); RETURN_NEW_STR(out_str); } /* }}} */ -/* {{{ php_raw_url_decode */ -PHPAPI size_t php_raw_url_decode(char *str, size_t len) +PHPAPI size_t php_raw_url_decode_ex(char *dest, const char *src, size_t src_len) { - char *dest = str; - char *data = str; + char *dest_start = dest; + const char *data = src; - while (len--) { - if (*data == '%' && len >= 2 && isxdigit((int) *(data + 1)) + while (src_len--) { + if (*data == '%' && src_len >= 2 && isxdigit((int) *(data + 1)) && isxdigit((int) *(data + 2))) { *dest = (char) php_htoi(data + 1); data += 2; - len -= 2; + src_len -= 2; } else { *dest = *data; } @@ -659,7 +666,13 @@ PHPAPI size_t php_raw_url_decode(char *str, size_t len) dest++; } *dest = '\0'; - return dest - str; + return dest - dest_start; +} + +/* {{{ php_raw_url_decode */ +PHPAPI size_t php_raw_url_decode(char *str, size_t len) +{ + return php_raw_url_decode_ex(str, str, len); } /* }}} */ diff --git a/ext/standard/url.h b/ext/standard/url.h index 4126ee6c6db40..5c531c0086a20 100644 --- a/ext/standard/url.h +++ b/ext/standard/url.h @@ -33,7 +33,9 @@ PHPAPI php_url *php_url_parse(char const *str); PHPAPI php_url *php_url_parse_ex(char const *str, size_t length); PHPAPI php_url *php_url_parse_ex2(char const *str, size_t length, bool *has_port); PHPAPI size_t php_url_decode(char *str, size_t len); /* return value: length of decoded string */ +PHPAPI size_t php_url_decode_ex(char *dest, const char *src, size_t src_len); PHPAPI size_t php_raw_url_decode(char *str, size_t len); /* return value: length of decoded string */ +PHPAPI size_t php_raw_url_decode_ex(char *dest, const char *src, size_t src_len); PHPAPI zend_string *php_url_encode(char const *s, size_t len); PHPAPI zend_string *php_raw_url_encode(char const *s, size_t len);