Merge branch 'rules' of git://github.com/mcfedr/phpstan-symfony into mcfedr-rules

Author: lookyman

README.md

@@ -37,6 +37,13 @@ If you don't want to use `phpstan/extension-installer`, include extension.neon i
 includes:
     - vendor/phpstan/phpstan-symfony/extension.neon
 ```
+
+To perform framework-specific checks, include also this file:
+
+```
+includes:
+    - vendor/phpstan/phpstan-symfony/rules.neon
+```
 </details>
 
 # Configuration
@@ -51,7 +58,6 @@ parameters:
         container_xml_path: '%rootDir%/../../../var/cache/dev/srcApp_KernelDevDebugContainer.xml'
 ```
 
-
 ## Constant hassers
 
 Sometimes, when you are dealing with optional dependencies, the `::has()` methods can cause problems. For example, the following construct would complain that the condition is always either on or off, depending on whether you have the dependency for `service` installed:

composer.json

@@ -18,7 +18,8 @@
     },
     "phpstan": {
       "includes": [
-        "extension.neon"
+        "extension.neon",
+        "rules.neon"
       ]
     }
   },

extension.neon

@@ -11,14 +11,6 @@ parametersSchema:
 		console_application_loader: schema(string(), nullable())
 	])
 
-rules:
-	- PHPStan\Rules\Symfony\ContainerInterfacePrivateServiceRule
-	- PHPStan\Rules\Symfony\ContainerInterfaceUnknownServiceRule
-	- PHPStan\Rules\Symfony\UndefinedArgumentRule
-	- PHPStan\Rules\Symfony\InvalidArgumentDefaultValueRule
-	- PHPStan\Rules\Symfony\UndefinedOptionRule
-	- PHPStan\Rules\Symfony\InvalidOptionDefaultValueRule
-
 services:
 	# console resolver
 	-

rules.neon

@@ -0,0 +1,8 @@
+rules:
+	- PHPStan\Rules\Symfony\ContainerInterfacePrivateServiceRule
+	- PHPStan\Rules\Symfony\ContainerInterfaceUnknownServiceRule
+	- PHPStan\Rules\Symfony\UndefinedArgumentRule
+	- PHPStan\Rules\Symfony\InvalidArgumentDefaultValueRule
+	- PHPStan\Rules\Symfony\UndefinedOptionRule
+	- PHPStan\Rules\Symfony\InvalidOptionDefaultValueRule
+

tests/Symfony/NeonTest.php

@@ -28,6 +28,7 @@ public function testExtensionNeon(): void
 			$compiler->addExtension('parametersSchema', new ParametersSchemaExtension());
 			$compiler->addConfig(['parameters' => ['rootDir' => __DIR__]]);
 			$compiler->loadConfig(__DIR__ . '/../../extension.neon');
+			$compiler->loadConfig(__DIR__ . '/../../rules.neon');
 			$compiler->loadConfig(__DIR__ . '/config.neon');
 		}, $key);
 		/** @var \Nette\DI\Container $container */