Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set an upper limit on the number of rows returned for the query log #3346

Merged
merged 1 commit into from
Mar 29, 2025

Conversation

PromoFaux
Copy link
Member

What does this PR aim to accomplish?:

Addresses #3345 . There is no world in which having "All" as an option on this table gives any real value. Even 1000 might be pushing it to be honest.

Added 500 as a step between 100 and 1000 because otherwise it seemed like a crazy jump to an arbitrarily high number - things can be changed.


By submitting this pull request, I confirm the following:

  1. I have read and understood the contributors guide, as well as this entire template. I understand which branch to base my commits and Pull Requests against.
  2. I have commented my proposed changes within the code and I have tested my changes.
  3. I am willing to help maintain this change if there are issues with it later.
  4. It is compatible with the EUPL 1.2 license
  5. I have squashed any insignificant commits. (git rebase)

  • I have read the above and my PR is ready for review. Check this box to confirm

… step between 100 and 1000)

Signed-off-by: Adam Warner <[email protected]>
@PromoFaux PromoFaux requested review from a team and Copilot March 26, 2025 21:42
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR limits the number of rows displayed for the query log by replacing the "All" option with fixed numeric values, adding intermediate steps between 100 and an imposed upper limit.

  • Removed the unlimited (-1/"All") option
  • Introduced 500 and 1000 as discrete row selection options

@PromoFaux
Copy link
Member Author

@Copilot err, thanks for the review I guess.

@yubiuser yubiuser linked an issue Mar 27, 2025 that may be closed by this pull request
@PromoFaux PromoFaux merged commit 51fc14a into development Mar 29, 2025
10 checks passed
@PromoFaux PromoFaux deleted the limit-datatables branch March 29, 2025 10:34
@PromoFaux PromoFaux mentioned this pull request Mar 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

opening Query Log freezes browser
2 participants