-
-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Flake outputs are misleading. #3
Comments
NB: I'm happy to make a PR. The issue is reproducible with Himalaya as well. |
The structure is not well documented yet, but the first level correspond to host platforms, the second the cross platforms. From |
Ah... I see. Okay. That makes sense. Maybe, just to make it clear for people, you could add - either a prefix or a suffix - That way it's obvious it's for cross-compiling. What are your thoughts on that? |
It allows this kind of things in CI, which I find great and I would like to keep it. It makes builds more predictable and reproducible. |
Agreed. Wouldn't a suffix/prefix be relatively easy to adjust in CI as well, though? I mean, it wouldn't be 'typical' user-facing, only for those like me who inspect the Flake, and even then, with documentation in the flake, it would be explained. |
Yes indeed, I like the proposition! |
Actually, I think it's best you do this. The Flake looks rather complex. |
As you wish. It should not take long for me to fix it, I already put my nose in recently. Thank you for proposing, feel free to submit other PRs if you want! |
I've been thinking about this some more. I may be wrong, but I believe nix/nixpkgs does support We could refactor the Flake here (and on the other projects) to export the I think this would be simpler than the current approach and/or adding a I suppose the ultimate goal is to upstream to Nixpkgs, right? |
Sorry, I realized I've never replied to you.
Should be definitely enough, would you like to propose a PR?
It's already available on Nixpkgs, but with another derivation. The best would be to use the same between both, do you think it's doable? |
The Flake is misleading. Packages should be
system
-specific, and not expose attrs of moresystem
s.Below is a screenshot. I would propose
arm64-linux
andx86_64-windows
to be moved up a level.The text was updated successfully, but these errors were encountered: