Skip to content

Commit 4ad369f

Browse files
committed
chore(rebase): refresh main conflict resolution
1 parent 56a1225 commit 4ad369f

5 files changed

Lines changed: 41 additions & 7 deletions

File tree

apps/server/src/orchestration/Layers/ProviderCommandReactor.ts

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -415,8 +415,7 @@ const make = Effect.gen(function* () {
415415
const cwd = input.worktreePath;
416416
const attachments = input.attachments ?? [];
417417
yield* Effect.gen(function* () {
418-
const { textGenerationModelSelection } =
419-
yield* serverSettingsService.getSettings;
418+
const { textGenerationModelSelection } = yield* serverSettingsService.getSettings;
420419

421420
const generated = yield* textGeneration.generateBranchName({
422421
cwd,

apps/server/src/orchestration/decider.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,7 @@ import {
1414
} from "./commandInvariants.ts";
1515

1616
const nowIso = () => new Date().toISOString();
17+
const DEFAULT_ASSISTANT_DELIVERY_MODE = "buffered" as const;
1718

1819
const defaultMetadata: Omit<OrchestrationEvent, "sequence" | "type" | "payload"> = {
1920
eventId: crypto.randomUUID() as OrchestrationEvent["eventId"],

apps/web/src/components/ChatView.tsx

Lines changed: 23 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -644,7 +644,27 @@ export default function ChatView({ threadId }: ChatViewProps) {
644644
[selectedModel, selectedModelOptionsForDispatch, selectedProvider],
645645
);
646646
const selectedTextGenerationModel = settings.textGenerationModelSelection.model;
647-
const providerOptionsForDispatch = useMemo(() => getProviderStartOptions(settings), [settings]);
647+
const providerOptionsForDispatch = useMemo(() => {
648+
const providerOptions = {
649+
...(settings.providers.codex.binaryPath || settings.providers.codex.homePath
650+
? {
651+
codex: {
652+
binaryPath: settings.providers.codex.binaryPath,
653+
homePath: settings.providers.codex.homePath,
654+
},
655+
}
656+
: {}),
657+
...(settings.providers.claudeAgent.binaryPath
658+
? {
659+
claudeAgent: {
660+
binaryPath: settings.providers.claudeAgent.binaryPath,
661+
},
662+
}
663+
: {}),
664+
};
665+
666+
return Object.keys(providerOptions).length > 0 ? providerOptions : undefined;
667+
}, [settings]);
648668
const selectedModelForPicker = selectedModel;
649669
const phase = derivePhase(activeThread?.session ?? null);
650670
const isSendBusy = sendPhase !== "idle";
@@ -3019,6 +3039,7 @@ export default function ChatView({ threadId }: ChatViewProps) {
30193039
const outgoingImplementationPrompt = formatOutgoingPrompt({
30203040
provider: selectedProvider,
30213041
model: selectedModel,
3042+
models: selectedProviderModels,
30223043
effort: selectedPromptEffort,
30233044
text: implementationPrompt,
30243045
});
@@ -3112,6 +3133,7 @@ export default function ChatView({ threadId }: ChatViewProps) {
31123133
selectedPromptEffort,
31133134
selectedModelSelection,
31143135
selectedProvider,
3136+
selectedProviderModels,
31153137
settings.enableAssistantStreaming,
31163138
providerOptionsForDispatch,
31173139
selectedTextGenerationModel,

apps/web/src/routes/_chat.settings.tsx

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -378,10 +378,6 @@ function SettingsRouteView() {
378378
: []),
379379
...(isGitWritingModelDirty ? ["Text generation model"] : []),
380380
...(areProviderSettingsDirty ? ["Providers"] : []),
381-
...(settings.customCodexModels.length > 0 || settings.customClaudeModels.length > 0
382-
? ["Custom models"]
383-
: []),
384-
...(isInstallSettingsDirty ? ["Provider installs"] : []),
385381
];
386382

387383
const openKeybindingsFile = useCallback(() => {

packages/contracts/src/orchestration.ts

Lines changed: 16 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,7 @@ import {
1111
ProjectId,
1212
ProviderItemId,
1313
ThreadId,
14+
TrimmedString,
1415
TrimmedNonEmptyString,
1516
TurnId,
1617
} from "./baseSchemas";
@@ -42,6 +43,21 @@ export const ProviderSandboxMode = Schema.Literals([
4243
"danger-full-access",
4344
]);
4445
export type ProviderSandboxMode = typeof ProviderSandboxMode.Type;
46+
47+
export const ProviderStartOptions = Schema.Struct({
48+
codex: Schema.optional(
49+
Schema.Struct({
50+
binaryPath: TrimmedString,
51+
homePath: TrimmedString,
52+
}),
53+
),
54+
claudeAgent: Schema.optional(
55+
Schema.Struct({
56+
binaryPath: TrimmedString,
57+
}),
58+
),
59+
});
60+
export type ProviderStartOptions = typeof ProviderStartOptions.Type;
4561
export const DEFAULT_PROVIDER_KIND: ProviderKind = "codex";
4662

4763
export const CodexModelSelection = Schema.Struct({

0 commit comments

Comments
 (0)