Skip to content

Conversation

@schnz
Copy link

@schnz schnz commented Jul 22, 2024

Fixes #144

@kibertoad
Copy link
Contributor

What Node versions is this compatible with?

@schnz schnz force-pushed the bugfix/stacktrace branch from 1fbcf91 to 3f67079 Compare July 22, 2024 11:38
@schnz
Copy link
Author

schnz commented Jul 22, 2024

Sorry, somehow the "engines.node" change in package.json didn't make it into the commit. Should be compatible with all node versions >= v12.

// Edit: >=v12.12.0 to be exact

@schnz schnz force-pushed the bugfix/stacktrace branch from 3f67079 to cccc817 Compare July 22, 2024 11:42
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

I will bump a major

@mcollina mcollina requested review from jsumners and kibertoad July 22, 2024 14:01
@mcollina
Copy link
Member

CI is failing. Can you skip Node.js v14 on Mac OS X?

@schnz schnz force-pushed the bugfix/stacktrace branch from cccc817 to fbb6ef8 Compare April 17, 2025 16:11
@schnz
Copy link
Author

schnz commented Apr 17, 2025

I've just rebased my PR based on #156, which was merged yesterday.

@jdbruijn
Copy link

Any update? I've had the same issue, all logs are at line 1, and removing the require('source-map-support/register') line worked for me as well. This is with pino-caller 4.0.0, pino 9.9.0 and Node v22.10.0.

I've validated both I get the correct output, file and line number, when using tsx and when using node --enable-source-maps. Please let me know if there's anything else I can do to get this PR merged.

@schnz
Copy link
Author

schnz commented Aug 18, 2025

No update from my side. For the time being, I've resorted to remove this line when debugging locally. But it would be nice to have this integrated upstream.

@jdbruijn
Copy link

jdbruijn commented Aug 18, 2025

I understand, this bump is mainly for @mcollina or @kibertoad I think. I was also able to verify using node --enable-source-maps --loader ts-node/esm, i.e. ts-node's ESM support, I get the correct line numbers without the source-map-support line. So to the best of my knowledge, I think this'd also fix #140.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

source-map-support incompatible with tsx

5 participants