-
Notifications
You must be signed in to change notification settings - Fork 15
fix: remove source-map-support package in favor of native NodeJS support #145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
What Node versions is this compatible with? |
|
Sorry, somehow the "engines.node" change in package.json didn't make it into the commit. Should be compatible with all node versions >= v12. // Edit: >=v12.12.0 to be exact |
mcollina
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
I will bump a major
|
CI is failing. Can you skip Node.js v14 on Mac OS X? |
cccc817 to
fbb6ef8
Compare
|
I've just rebased my PR based on #156, which was merged yesterday. |
|
Any update? I've had the same issue, all logs are at line 1, and removing the I've validated both I get the correct output, file and line number, when using |
|
No update from my side. For the time being, I've resorted to remove this line when debugging locally. But it would be nice to have this integrated upstream. |
|
I understand, this bump is mainly for @mcollina or @kibertoad I think. I was also able to verify using |
Fixes #144