Merge pull request #28 from chyipin/fix-getall-loop

andrewkarell · web-flow · commit 850dec77e40b · 2016-12-08T10:51:31.000+02:00
Prevent getAll looping indefinitely when error occurs
diff --git a/lib/Pipedrive.js b/lib/Pipedrive.js
@@ -199,7 +199,7 @@ THE SOFTWARE.
 				}
 				self[resource].getAll(params, function(err, models) {
 					if (err) {
-						callback(err);
+						return callback(err);
 					} else {
 						collection = collection.concat(models);
 						if (models.length < perPage) {

Original file line number	Diff line number	Diff line change
`@@ -199,7 +199,7 @@ THE SOFTWARE.`
`199`	`199`	`}`
`200`	`200`	`self[resource].getAll(params, function(err, models) {`
`201`	`201`	`if (err) {`
`202`		`- callback(err);`
	`202`	`+ return callback(err);`
`203`	`203`	`} else {`
`204`	`204`	`collection = collection.concat(models);`
`205`	`205`	`if (models.length < perPage) {`