Add several Sonar hotspot mappings (#486)

Author: nahsra

.github/workflows/checks.yml

@@ -64,7 +64,7 @@ jobs:
           python-version: '3.11'
 
       - name: Install Semgrep
-        run: python3 -m pip install semgrep
+        run: python3 -m pip install semgrep==1.84.1
 
       - name: Run Check task
         uses: gradle/gradle-build-action@842c587ad8aa4c68eeba24c396e15af4c2e9f30a # v2.9.0

.github/workflows/release.yml

@@ -28,7 +28,7 @@ jobs:
           python-version: '3.11'
 
       - name: Install Semgrep
-        run: python3 -m pip install semgrep
+        run: python3 -m pip install semgrep==1.84.1
 
       - uses: actions/setup-java@v3
         with:

README.md

@@ -27,7 +27,7 @@ Follow these instructions if you intend to modify and build this project from so
    [here](https://semgrep.dev/docs/getting-started/#installing-and-running-semgrep-locally)
    for instructions. It can usually be done via `pip`:
    ```shell
-   pip install semgrep
+   pip install semgrep==1.84.1
    ```
 
 If your python library paths contain your home directory as a root folder (i.e.

core-codemods/src/intTest/java/io/codemodder/integration/GitRepositoryTest.java

@@ -97,7 +97,12 @@ protected void verifyNoFailedFiles(final CodeTFReport report) {
             .map(CodeTFResult::getFailedFiles)
             .flatMap(Collection::stream)
             .toList();
-    assertThat(failedFiles.size(), is(0));
+    if (!failedFiles.isEmpty()) {
+      System.out.println("Failed files during scan:");
+      failedFiles.forEach(System.err::println);
+    }
+    int size = failedFiles.size();
+    assertThat(size, is(0));
   }
 
   protected void verifyStandardCodemodResults(final List<CodeTFChangesetEntry> fileChanges) {

core-codemods/src/main/java/io/codemodder/codemods/DefaultCodemods.java

@@ -12,6 +12,7 @@
 import io.codemodder.codemods.semgrep.SemgrepServletResponseWriterXSSCodemod;
 import io.codemodder.codemods.semgrep.SemgrepWeakRandomCodemod;
 import io.codemodder.codemods.semgrep.SemgrepXXECodemod;
+import io.codemodder.codemods.sonar.*;
 import java.util.List;
 
 /**
@@ -89,12 +90,15 @@ public static List<Class<? extends CodeChanger>> asList() {
         SemgrepOverlyPermissiveFilePermissionsCodemod.class,
         SimplifyRestControllerAnnotationsCodemod.class,
         SubstituteReplaceAllCodemod.class,
+        SonarCookieMissingSecureFlagCodemod.class,
         SonarJNDIInjectionCodemod.class,
         SonarObjectDeserializationCodemod.class,
         SonarRemoveUnthrowableExceptionCodemod.class,
         SonarSQLInjectionCodemod.class,
         SonarSSRFCodemod.class,
         SonarUnsafeReflectionRemediationCodemod.class,
+        SonarWeakHashingAlgorithmCodemod.class,
+        SonarWeakRandomCodemod.class,
         SonarXXECodemod.class,
         SQLParameterizerCodemod.class,
         SSRFCodemod.class,

core-codemods/src/main/java/io/codemodder/codemods/AddMissingOverrideCodemod.java renamed to core-codemods/src/main/java/io/codemodder/codemods/sonar/AddMissingOverrideCodemod.java

@@ -1,4 +1,4 @@
-package io.codemodder.codemods;
+package io.codemodder.codemods.sonar;
 
 import com.github.javaparser.ast.CompilationUnit;
 import com.github.javaparser.ast.body.MethodDeclaration;

core-codemods/src/main/java/io/codemodder/codemods/AvoidImplicitPublicConstructorCodemod.java renamed to core-codemods/src/main/java/io/codemodder/codemods/sonar/AvoidImplicitPublicConstructorCodemod.java

@@ -1,4 +1,4 @@
-package io.codemodder.codemods;
+package io.codemodder.codemods.sonar;
 
 import com.github.javaparser.ast.CompilationUnit;
 import com.github.javaparser.ast.Modifier;

core-codemods/src/main/java/io/codemodder/codemods/ConstantNameStringGenerator.java renamed to core-codemods/src/main/java/io/codemodder/codemods/sonar/ConstantNameStringGenerator.java

@@ -1,4 +1,4 @@
-package io.codemodder.codemods;
+package io.codemodder.codemods.sonar;
 
 import java.util.Set;
 import java.util.regex.Matcher;

core-codemods/src/main/java/io/codemodder/codemods/CreateConstantForLiteral.java renamed to core-codemods/src/main/java/io/codemodder/codemods/sonar/CreateConstantForLiteral.java

@@ -1,4 +1,4 @@
-package io.codemodder.codemods;
+package io.codemodder.codemods.sonar;
 
 import com.github.javaparser.ast.CompilationUnit;
 import com.github.javaparser.ast.Modifier;

core-codemods/src/main/java/io/codemodder/codemods/DeclareVariableOnSeparateLine.java renamed to core-codemods/src/main/java/io/codemodder/codemods/sonar/DeclareVariableOnSeparateLine.java

@@ -1,4 +1,4 @@
-package io.codemodder.codemods;
+package io.codemodder.codemods.sonar;
 
 import com.github.javaparser.ast.Node;
 import com.github.javaparser.ast.NodeList;