chore(phpcs): adds EndFileNewline to phpcs (#23)

https://pixelfederation.atlassian.net/browse/TS2-18528

Author: thomasooo

phpcs.ruleset.83.xml

@@ -227,6 +227,9 @@
   <rule ref="Squiz.WhiteSpace.SuperfluousWhitespace.BeforeCloseBrace">
     <severity>5</severity>
   </rule>
+  <rule ref="Generic.Files.EndFileNewline">
+    <severity>5</severity>
+  </rule>
 
   <rule ref="Zend.Files.ClosingTag"/>
 

tests/Functional/PhpcsTestCase.php

@@ -5,9 +5,23 @@
 namespace PixelFederation\CodingStandards\Tests\Functional;
 
 use PHPUnit\Framework\TestCase;
+use RuntimeException;
 
 abstract class PhpcsTestCase extends TestCase
 {
+    public static function trimEndFileNewline(string $file): void
+    {
+        $file = __DIR__ . '/' . $file;
+        $content = file_get_contents($file);
+        if ($content === false) {
+            throw new RuntimeException('Could not read file: ' . $file);
+        }
+
+        $trimmedContent = rtrim($content, "\n");
+
+        file_put_contents($file, $trimmedContent);
+    }
+
     public static function assertPhpcbf(
         string $fileBefore,
         string $fileAfter,

tests/Functional/SuperfluousWhitespace/Bar.SuperfluousWhitespace.before.php

@@ -30,4 +30,4 @@ public function __construct(
         $this->superNumber = $total + $heightDoubled;
     }
 
-}
+}

tests/Functional/SuperfluousWhitespaceTest.php

@@ -8,9 +8,12 @@ final class SuperfluousWhitespaceTest extends PhpcsTestCase
 {
     public function testPhpcbfFixesWhitespaceAsExpected(): void
     {
-        self::assertPhpcbf(
-            'SuperfluousWhitespace/Bar.SuperfluousWhitespace.before.php',
-            'SuperfluousWhitespace/Bar.SuperfluousWhitespace.after.php',
-        );
+        $fileBefore = 'SuperfluousWhitespace/Bar.SuperfluousWhitespace.before.php';
+        $fileAfter = 'SuperfluousWhitespace/Bar.SuperfluousWhitespace.after.php';
+
+        // Ensure no trailing newlines interfere with the comparison
+        self::trimEndFileNewline($fileBefore);
+
+        self::assertPhpcbf($fileBefore, $fileAfter);
     }
 }