Skip to content

Commit 77a0900

Browse files
committed
fix: remove duplicate SM Lab cascade preview
Fixes #116
1 parent f7843fb commit 77a0900

2 files changed

Lines changed: 3 additions & 56 deletions

File tree

src/Lab/ShowcaseRenderer.php

Lines changed: 0 additions & 48 deletions
Original file line numberDiff line numberDiff line change
@@ -204,7 +204,6 @@ class="sm-lab-signal-cascade"
204204
data-sm-lab-cascade-palette="<?php echo esc_attr( $params->palette() ); ?>"
205205
data-sm-lab-cascade-active-signal="<?php echo esc_attr( (string) $params->signal() ); ?>"
206206
>
207-
<?php $this->render_cascade_assembled_preview( $params, $parent_variation ); ?>
208207
<?php $this->render_cascade_inspector( $params, $parent_variation ); ?>
209208
</div>
210209
</article>
@@ -327,53 +326,6 @@ private function get_component_token_style( int $label_grade, int $button_grade,
327326
);
328327
}
329328

330-
private function render_cascade_assembled_preview( QueryParams $params, int $root_variation ): void {
331-
$nodes = $this->get_signal_cascade_nodes( $params, $root_variation );
332-
$by_id = [];
333-
334-
foreach ( $nodes as $node ) {
335-
$by_id[ $node['id'] ] = $node;
336-
}
337-
?>
338-
<div class="sm-lab-signal-cascade__assembled" data-sm-lab-cascade-view="assembled" aria-label="<?php esc_attr_e( 'Assembled page preview with resolved block surfaces', '__plugin_txtd' ); ?>">
339-
<div
340-
class="sm-lab-cascade-preview-node sm-lab-cascade-preview-node--page"
341-
data-sm-lab-cascade-preview-node="page"
342-
style="<?php echo esc_attr( $this->get_signal_cascade_style( $by_id['page']['resolved_grade'], $by_id['page']['text_grade'], $by_id['page']['signal'] ) ); ?>"
343-
>
344-
<div
345-
class="sm-lab-cascade-preview-node sm-lab-cascade-preview-node--header"
346-
data-sm-lab-cascade-preview-node="header"
347-
data-sm-lab-cascade-bridge="header"
348-
style="<?php echo esc_attr( $this->get_signal_cascade_style( $by_id['header']['resolved_grade'], $by_id['header']['text_grade'], $by_id['header']['signal'] ) ); ?>"
349-
></div>
350-
<div
351-
class="sm-lab-cascade-preview-node sm-lab-cascade-preview-node--content"
352-
data-sm-lab-cascade-preview-node="content"
353-
style="<?php echo esc_attr( $this->get_signal_cascade_style( $by_id['content']['resolved_grade'], $by_id['content']['text_grade'], $by_id['content']['signal'] ) ); ?>"
354-
>
355-
<div
356-
class="sm-lab-cascade-preview-node sm-lab-cascade-preview-node--inner"
357-
data-sm-lab-cascade-preview-node="inner"
358-
style="<?php echo esc_attr( $this->get_signal_cascade_style( $by_id['inner']['resolved_grade'], $by_id['inner']['text_grade'], $by_id['inner']['signal'] ) ); ?>"
359-
>
360-
<div
361-
class="sm-lab-cascade-preview-node sm-lab-cascade-preview-node--second-inner"
362-
data-sm-lab-cascade-preview-node="second-inner"
363-
style="<?php echo esc_attr( $this->get_signal_cascade_style( $by_id['second-inner']['resolved_grade'], $by_id['second-inner']['text_grade'], $by_id['second-inner']['signal'] ) ); ?>"
364-
></div>
365-
</div>
366-
</div>
367-
<div
368-
class="sm-lab-cascade-preview-node sm-lab-cascade-preview-node--footer"
369-
data-sm-lab-cascade-preview-node="footer"
370-
style="<?php echo esc_attr( $this->get_signal_cascade_style( $by_id['footer']['resolved_grade'], $by_id['footer']['text_grade'], $by_id['footer']['signal'] ) ); ?>"
371-
></div>
372-
</div>
373-
</div>
374-
<?php
375-
}
376-
377329
private function render_cascade_inspector( QueryParams $params, int $root_variation ): void {
378330
$nodes = $this->get_signal_cascade_nodes( $params, $root_variation );
379331
$by_parent = [];

tests/phpunit/Unit/Lab/ShowcaseRendererTest.php

Lines changed: 3 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,6 @@ public function test_render_outputs_unique_value_showcase_sections(): void {
5555
$this->assertStringContainsString( 'data-sm-lab-resolution-stage="mapping"', $html );
5656
$this->assertStringContainsString( 'sm-lab-resolution-stage--wide', $html );
5757
$this->assertStringContainsString( 'data-sm-lab-signal-cascade', $html );
58-
$this->assertStringContainsString( 'data-sm-lab-cascade-view="assembled"', $html );
5958
$this->assertStringContainsString( 'data-sm-lab-cascade-view="inspector"', $html );
6059
$this->assertStringContainsString( 'data-sm-lab-cascade-node="page"', $html );
6160
$this->assertStringContainsString( 'data-sm-lab-cascade-node="content"', $html );
@@ -76,13 +75,9 @@ public function test_render_outputs_unique_value_showcase_sections(): void {
7675
$this->assertStringContainsString( '--sm-lab-cascade-surface-color', $html );
7776
$this->assertStringContainsString( '--sm-lab-cascade-border-width: 2px;', $html );
7877
$this->assertStringContainsString( '--sm-lab-cascade-border-width: 1px;', $html );
79-
$this->assertStringContainsString( 'data-sm-lab-cascade-preview-node="page"', $html );
80-
$this->assertStringContainsString( 'data-sm-lab-cascade-preview-node="header"', $html );
81-
$this->assertStringContainsString( 'data-sm-lab-cascade-preview-node="content"', $html );
82-
$this->assertStringContainsString( 'data-sm-lab-cascade-preview-node="inner"', $html );
83-
$this->assertStringContainsString( 'data-sm-lab-cascade-preview-node="second-inner"', $html );
84-
$this->assertStringContainsString( 'data-sm-lab-cascade-preview-node="footer"', $html );
85-
$this->assertStringContainsString( 'data-sm-lab-cascade-bridge="header"', $html );
78+
$this->assertStringNotContainsString( 'data-sm-lab-cascade-view="assembled"', $html );
79+
$this->assertStringNotContainsString( 'data-sm-lab-cascade-preview-node', $html );
80+
$this->assertStringNotContainsString( 'data-sm-lab-cascade-bridge="header"', $html );
8681
$this->assertStringContainsString( 'data-sm-lab-anatomy-bridge="header"', $html );
8782
$this->assertStringContainsString( 'data-sm-lab-cascade-resolved-grade="6"', $html );
8883
$this->assertStringContainsString( 'data-sm-lab-cascade-resolved-grade="10"', $html );

0 commit comments

Comments
 (0)