Skip to content

Commit 4e19aab

Browse files
committed
no need to dispose the SXSSFWorkbook any more
1 parent 0feb92b commit 4e19aab

File tree

2 files changed

+6
-11
lines changed

2 files changed

+6
-11
lines changed

src/test/java/com/github/pjfanning/xlsx/CopyToSXSSFUtil.java

+2-1
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,8 @@ public static SXSSFWorkbook copyToSXSSF(final InputStream inputStream) throws Ex
4242
*/
4343
}
4444
} catch (Exception e) {
45-
sxssfWorkbook.dispose();
45+
// since POI 5.3.0, you no longer need to call dispose() on SXSSFWorkbook
46+
sxssfWorkbook.close();
4647
throw e;
4748
}
4849
return sxssfWorkbook;

src/test/java/com/github/pjfanning/xlsx/StreamingReaderTest.java

+4-10
Original file line numberDiff line numberDiff line change
@@ -1573,12 +1573,9 @@ public void copyToSXSSF() throws Exception {
15731573
InputStream inputStream = new FileInputStream("src/test/resources/stream_reader_test.xlsx");
15741574
UnsynchronizedByteArrayOutputStream bos = UnsynchronizedByteArrayOutputStream.builder().get()
15751575
) {
1576-
SXSSFWorkbook wbOutput = CopyToSXSSFUtil.copyToSXSSF(inputStream);
1577-
try {
1576+
// since POI 5.3.0, you no longer need to call dispose() on SXSSFWorkbook
1577+
try (SXSSFWorkbook wbOutput = CopyToSXSSFUtil.copyToSXSSF(inputStream)) {
15781578
wbOutput.write(bos);
1579-
} finally {
1580-
wbOutput.close();
1581-
wbOutput.dispose();
15821579
}
15831580

15841581
try (XSSFWorkbook xssfWorkbook = new XSSFWorkbook(bos.toInputStream())) {
@@ -1624,12 +1621,9 @@ public void copyToSXSSFWithHyperlinks() throws Exception {
16241621
InputStream inputStream = new FileInputStream("src/test/resources/59775.xlsx");
16251622
UnsynchronizedByteArrayOutputStream bos = UnsynchronizedByteArrayOutputStream.builder().get()
16261623
) {
1627-
SXSSFWorkbook wbOutput = CopyToSXSSFUtil.copyToSXSSF(inputStream);
1628-
try {
1624+
// since POI 5.3.0, you no longer need to call dispose() on SXSSFWorkbook
1625+
try (SXSSFWorkbook wbOutput = CopyToSXSSFUtil.copyToSXSSF(inputStream)) {
16291626
wbOutput.write(bos);
1630-
} finally {
1631-
wbOutput.close();
1632-
wbOutput.dispose();
16331627
}
16341628

16351629
try (XSSFWorkbook xssfWorkbook = new XSSFWorkbook(bos.toInputStream())) {

0 commit comments

Comments
 (0)