Skip to content

Commit 2484096

Browse files
authored
Merge pull request #6 from plainerman/feature-dotnet-standard
Convert to .Net Standard 2.0
2 parents da37e2a + f4d3555 commit 2484096

File tree

4 files changed

+21
-35
lines changed

4 files changed

+21
-35
lines changed

TicTacTube.sln

Lines changed: 17 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -1,37 +1,37 @@
11

22
Microsoft Visual Studio Solution File, Format Version 12.00
33
# Visual Studio 15
4-
VisualStudioVersion = 15.0.27004.2002
4+
VisualStudioVersion = 15.0.27130.2003
55
MinimumVisualStudioVersion = 10.0.40219.1
6-
Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "TicTacTubeCore", "TicTacTubeCore\TicTacTubeCore.csproj", "{1287B36D-9373-43AA-8989-4C8AF04743D3}"
6+
Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "TicTacTubeCore", "TicTacTubeCore\TicTacTubeCore.csproj", "{BB5B48E9-CAE9-4DEC-B32A-B1C19B7DCD6C}"
77
EndProject
8-
Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "TicTacTubeCoreTest", "TicTacTubeCoreTest\TicTacTubeCoreTest.csproj", "{5F41AB71-4DF3-4BB2-B3B4-9D3389526385}"
8+
Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "TicTacTubeCoreTest", "TicTacTubeCoreTest\TicTacTubeCoreTest.csproj", "{A92C66F1-1039-4017-8403-6B5E063E58F5}"
99
EndProject
10-
Project("{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}") = "TicTacTubeDemo", "TicTacTubeDemo\TicTacTubeDemo.csproj", "{A943BFE1-8610-4CA8-B8D3-C9B8BAC34525}"
10+
Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "TicTacTubeDemo", "TicTacTubeDemo\TicTacTubeDemo.csproj", "{12CDF96B-D6F2-4114-BB8D-5019B38B1A6E}"
1111
EndProject
1212
Global
1313
GlobalSection(SolutionConfigurationPlatforms) = preSolution
1414
Debug|Any CPU = Debug|Any CPU
1515
Release|Any CPU = Release|Any CPU
1616
EndGlobalSection
1717
GlobalSection(ProjectConfigurationPlatforms) = postSolution
18-
{1287B36D-9373-43AA-8989-4C8AF04743D3}.Debug|Any CPU.ActiveCfg = Debug|Any CPU
19-
{1287B36D-9373-43AA-8989-4C8AF04743D3}.Debug|Any CPU.Build.0 = Debug|Any CPU
20-
{1287B36D-9373-43AA-8989-4C8AF04743D3}.Release|Any CPU.ActiveCfg = Release|Any CPU
21-
{1287B36D-9373-43AA-8989-4C8AF04743D3}.Release|Any CPU.Build.0 = Release|Any CPU
22-
{5F41AB71-4DF3-4BB2-B3B4-9D3389526385}.Debug|Any CPU.ActiveCfg = Debug|Any CPU
23-
{5F41AB71-4DF3-4BB2-B3B4-9D3389526385}.Debug|Any CPU.Build.0 = Debug|Any CPU
24-
{5F41AB71-4DF3-4BB2-B3B4-9D3389526385}.Release|Any CPU.ActiveCfg = Release|Any CPU
25-
{5F41AB71-4DF3-4BB2-B3B4-9D3389526385}.Release|Any CPU.Build.0 = Release|Any CPU
26-
{A943BFE1-8610-4CA8-B8D3-C9B8BAC34525}.Debug|Any CPU.ActiveCfg = Debug|Any CPU
27-
{A943BFE1-8610-4CA8-B8D3-C9B8BAC34525}.Debug|Any CPU.Build.0 = Debug|Any CPU
28-
{A943BFE1-8610-4CA8-B8D3-C9B8BAC34525}.Release|Any CPU.ActiveCfg = Release|Any CPU
29-
{A943BFE1-8610-4CA8-B8D3-C9B8BAC34525}.Release|Any CPU.Build.0 = Release|Any CPU
18+
{BB5B48E9-CAE9-4DEC-B32A-B1C19B7DCD6C}.Debug|Any CPU.ActiveCfg = Debug|Any CPU
19+
{BB5B48E9-CAE9-4DEC-B32A-B1C19B7DCD6C}.Debug|Any CPU.Build.0 = Debug|Any CPU
20+
{BB5B48E9-CAE9-4DEC-B32A-B1C19B7DCD6C}.Release|Any CPU.ActiveCfg = Release|Any CPU
21+
{BB5B48E9-CAE9-4DEC-B32A-B1C19B7DCD6C}.Release|Any CPU.Build.0 = Release|Any CPU
22+
{A92C66F1-1039-4017-8403-6B5E063E58F5}.Debug|Any CPU.ActiveCfg = Debug|Any CPU
23+
{A92C66F1-1039-4017-8403-6B5E063E58F5}.Debug|Any CPU.Build.0 = Debug|Any CPU
24+
{A92C66F1-1039-4017-8403-6B5E063E58F5}.Release|Any CPU.ActiveCfg = Release|Any CPU
25+
{A92C66F1-1039-4017-8403-6B5E063E58F5}.Release|Any CPU.Build.0 = Release|Any CPU
26+
{12CDF96B-D6F2-4114-BB8D-5019B38B1A6E}.Debug|Any CPU.ActiveCfg = Debug|Any CPU
27+
{12CDF96B-D6F2-4114-BB8D-5019B38B1A6E}.Debug|Any CPU.Build.0 = Debug|Any CPU
28+
{12CDF96B-D6F2-4114-BB8D-5019B38B1A6E}.Release|Any CPU.ActiveCfg = Release|Any CPU
29+
{12CDF96B-D6F2-4114-BB8D-5019B38B1A6E}.Release|Any CPU.Build.0 = Release|Any CPU
3030
EndGlobalSection
3131
GlobalSection(SolutionProperties) = preSolution
3232
HideSolutionNode = FALSE
3333
EndGlobalSection
3434
GlobalSection(ExtensibilityGlobals) = postSolution
35-
SolutionGuid = {439D5826-657F-42B4-9926-3537273F0EE3}
35+
SolutionGuid = {A698C72B-C920-48AB-AFA8-ECAF5A3D1CE0}
3636
EndGlobalSection
3737
EndGlobal

TicTacTube.sln.DotSettings

Lines changed: 0 additions & 6 deletions
This file was deleted.

TicTacTubeCore/Sources/Files/External/BaseExternalFileSource.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,7 @@ public string FetchFile(string destinationPath)
4545
CurrentDownloadTask.Wait();
4646

4747
// If there was an error with the task
48-
if (!CurrentDownloadTask.IsCompletedSuccessfully)
48+
if (CurrentDownloadTask.IsFaulted)
4949
{
5050
Exception e = CurrentDownloadTask.Exception;
5151
CurrentDownloadTask = null;
Lines changed: 3 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,8 @@
11
<Project Sdk="Microsoft.NET.Sdk">
22

33
<PropertyGroup>
4-
<TargetFramework>netcoreapp2.0</TargetFramework>
5-
<GeneratePackageOnBuild>true</GeneratePackageOnBuild>
4+
<TargetFramework>netstandard2.0</TargetFramework>
5+
<GeneratePackageOnBuild>true</GeneratePackageOnBuild>
66
<PackageId>TicTacTube</PackageId>
77
<Authors>Michael Plainer</Authors>
88
<Company>Michael Plainer</Company>
@@ -20,17 +20,9 @@
2020
<FileVersion>0.2.0.0</FileVersion>
2121
</PropertyGroup>
2222

23-
<PropertyGroup Condition="'$(Configuration)|$(Platform)'=='Debug|AnyCPU'">
24-
<DocumentationFile>bin\Debug\netcoreapp2.0\TicTacTubeCore.xml</DocumentationFile>
25-
</PropertyGroup>
26-
27-
<PropertyGroup Condition="'$(Configuration)|$(Platform)'=='Release|AnyCPU'">
28-
<DocumentationFile>bin\Release\netcoreapp2.0\TicTacTubeCore.xml</DocumentationFile>
29-
</PropertyGroup>
30-
3123
<ItemGroup>
3224
<PackageReference Include="log4net" Version="2.0.8" />
3325
<PackageReference Include="taglib-sharp-netstandard2.0" Version="2.1.0" />
3426
</ItemGroup>
3527

36-
</Project>
28+
</Project>

0 commit comments

Comments
 (0)