Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setup deps.cljs for google-closure-compiler-js #932

Open
mfikes opened this issue May 21, 2019 · 1 comment
Open

Setup deps.cljs for google-closure-compiler-js #932

mfikes opened this issue May 21, 2019 · 1 comment

Comments

@mfikes
Copy link
Member

mfikes commented May 21, 2019

When creating a namespace-only JAR (for the purpose of dependencies), the use of google-closure-compiler-js in the planck.bundle namespace trips up cljdoc (and perhaps other tools that attempt to statically analyze things).

Currently, this is worked around by temporarily commenting out the (:require ) before building the JAR. But if we include a deps.cljs, we may be able to work around this, without harming functionality of Planck in any way.

@mfikes
Copy link
Member Author

mfikes commented May 21, 2019

See

:foreign-libs [{:file "jscomp.js"
:provides ["google-closure-compiler-js"]}]

(We might be able to point it at an empty / stub JS file that is included in the JAR instead of the full jscomp.js.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant