diff --git a/.gitignore b/.gitignore index 3088081b9..7d69a814c 100644 --- a/.gitignore +++ b/.gitignore @@ -24,6 +24,5 @@ coverage.xml # Editors .vscode/ - # Docs build site diff --git a/planet/order_request.py b/planet/order_request.py index 51baa9f14..f36644ca6 100644 --- a/planet/order_request.py +++ b/planet/order_request.py @@ -199,6 +199,10 @@ def delivery(archive_type: Optional[str] = None, if archive_type: archive_type = specs.validate_archive_type(archive_type) + # for missing archive file name + if archive_filename is None: + archive_filename = "{{name}}_{{order_id}}.zip" + fields = ['archive_type', 'single_archive', 'archive_filename'] values = [archive_type, single_archive, archive_filename] diff --git a/tests/unit/test_order_request.py b/tests/unit/test_order_request.py index 0fc21dbfd..e702cce72 100644 --- a/tests/unit/test_order_request.py +++ b/tests/unit/test_order_request.py @@ -160,6 +160,31 @@ def test_delivery(): assert delivery_config == expected +def test_delivery_missing_archive_details(): + as3_config = { + 'amazon_s3': { + 'aws_access_key_id': 'aws_access_key_id', + 'aws_secret_access_key': 'aws_secret_access_key', + 'bucket': 'bucket', + 'aws_region': 'aws_region' + } + } + delivery_config = order_request.delivery(archive_type='zip', + cloud_config=as3_config) + + expected = { + 'archive_type': 'zip', + 'archive_filename': "{{name}}_{{order_id}}.zip", + 'amazon_s3': { + 'aws_access_key_id': 'aws_access_key_id', + 'aws_secret_access_key': 'aws_secret_access_key', + 'bucket': 'bucket', + 'aws_region': 'aws_region' + } + } + assert delivery_config == expected + + def test_amazon_s3(): as3_config = order_request.amazon_s3('aws_access_key_id', 'aws_secret_access_key',