[Feature request] Allow for Service name overrides

[walkamongus]

I ran into an issue exposing endpoints externally when trying to use an Ingress resource. If the VitessCluster CRD allowed for overriding Service names via serviceOverrides then users would be able to set a predictable name for Service resources. That would allow users to inject an Ingress resource via Helm or Kustomize that references the correct Service name. Alternatively -- for more work (and likely more fragile implementation) -- the custom resource itself could be extended with Ingress support.

[oavril]

Hi !

I'm also interested in adding the ability to override the name and add labeling of services to create a helm including an ingress and a loadBalancer.

Unless you provide an official helm chart?

[frouioui]

Hi @walkamongus isn't the service field of the vtgate CRD sufficient for this?

vitess-operator/pkg/apis/planetscale/v2/vitesscell_types.go

Line 223 in 23decc9

Service *ServiceOverrides `json:"service,omitempty"`

[luismacosta]

vitess-operator/pkg/apis/planetscale/v2/vitesscell_types.go

Hello @frouioui @mattlord

This was also reported:

#305
#405

Should be at CRD vitessclusters, define the serviceName for vtgate and vtctld.

For vtgate service I believe that should be here, but there is no serviceName property
For vtctld, I cannot find any reference for service creation in CRD
Also, I would say that the CRD should contain a section to create ingress for vtgate and vtctld

At the moment, once there is no support for this in the helm chart, I've created my own templates:
service-vtgate.yaml
service-vtctld.yaml
ingress-vtgate.yaml
ingress-vtctld.yaml

The same for vtadmin. Would be nice to have a way to expose 2 ingress: UI and api.

Regarding ingress for vtagte/vtctld/vtadmin, maybe in vitessclusters CRD spec:

ingress:
  properties:
    annotations:
      additionalProperties:
        type: string
      type: object
    className:
      type: string
    labels:
      additionalProperties:
        type: string
      type: object
    serviceName:
       type: string
    hostName:
      type: string
    tls:
      items:
        properties:
          hosts:
            items:
              type: string
            type: array
          secretName:
            type: string
        type: object
      type: array
  type: object