Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add proguard rules for Android #499

Open
chris-fitzgerald-ck opened this issue Aug 30, 2024 · 0 comments
Open

Add proguard rules for Android #499

chris-fitzgerald-ck opened this issue Aug 30, 2024 · 0 comments
Labels
Android Android Player Related Work enhancement New feature or request

Comments

@chris-fitzgerald-ck
Copy link

Is your feature request related to a problem? Please describe.
Integrating player into a library with minification on would be easier with a sample proguard file. Defining the least needed rules would also allow clients to integrate while adding the most obfuscated and minified build possible.

Describe the solution you'd like
It would be nice to have a sample proguard file that keeps all the classes that are used across the bridge with reflection, but still allows unused code to be stripped (or at least obfuscated).

Additional context
Currently, our rules look like this for player:

# These libraries use reflection for bridge methods between the JNI and JVM
-keep @com.facebook.jni.annotations.DoNotStrip public class * { *; }
-keep @com.facebook.jni.annotations.DoNotStripAny public class * { *; }
-keep class com.intuit.playerui.** { *; }
-keepnames class * extends com.intuit.playerui.jsi.HostFunctionInterface { *; }
@chris-fitzgerald-ck chris-fitzgerald-ck added the enhancement New feature or request label Aug 30, 2024
@KetanReddy KetanReddy added the Android Android Player Related Work label Aug 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Android Android Player Related Work enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants