feat: Filter invalid ObjectId constructor types in getIds

Author: duncanbeevers

src/__tests__/utils.test.ts

@@ -404,6 +404,11 @@ describe('utils', () => {
         ['123456789012345678900014', new ObjectId('123456789012345678900088')],
         [new ObjectId('123456789012345678900014'), new ObjectId('123456789012345678900088')],
       ],
+      [
+        'invalid',
+        ['123', '123456789012345678900021'],
+        [new ObjectId('123456789012345678900021')]
+      ],
     ])('%s', (_name, input, expected) => {
       expect.assertions(4);
 

src/utils.ts

@@ -196,7 +196,13 @@ export type RequireAtLeastOne<TObj, Keys extends keyof TObj = keyof TObj> = {
 
 export type ObjectIdConstructorParameter = ConstructorParameters<typeof ObjectId>[0];
 export function getIds(ids: Iterable<ObjectIdConstructorParameter>): ObjectId[] {
-  return Array.from(ids).map((id) => new ObjectId(id));
+  return Array.from(ids).flatMap((id) => {
+    try {
+      return new ObjectId(id);
+    } catch {
+      return [];
+    }
+  });
 }
 
 /**