PLIP: make plone.app.discussion a core add-on [6.1] #3958
Comments
|
I updated the original PLIP regarding the docs from a single item to two items, and created a pull request to address one of them in plone/documentation#1666 |
tisto
moved this from Submitted (info complete)
to In Process (approved)
in PLIPs (core)
|
For what it is worth, I approve this PLIP and moved it to "approved" column in the PLIP overview: https://github.com/orgs/plone/projects/47/views/1 @plone/framework-team @plone/release-team feel free to chime in. @mauritsvanrees @jensens what's the status of this PLIP? Isn't this merged already? |
|
Last (manual) tests and fixes addressing updates from Plone 5.2/6.0 are open. |
|
I have added an upgrade step in plone/plone.app.upgrade#330. See testing hints there. I have merged main/master in the PR branches of the other packages. This seems ready now. |
|
Please merge if everything is ready! |
|
Last call for reviews. Without further comments I intend to merge this at the end of this week or beginning of next week. |
|
I will merge everything now. |
|
All is merged. Jenkins may take some time getting green again, but should be fine after all merges have really landed. There was some documentation already, but could be extended for clarity. I will have a go at that. |
This is for the PLIP that I have just merged: plone/Products.CMFPlone#3958 I changed the existing section title from "Discussion is disabled by default" to "Discussion is a core add-on". Discussion was always disabled by default, so this would not be a change. Note that the Discussion control panel is still missing from Volto: plone/volto#29 But the upgrade to 6.1 does not change anything to this.
|
Documentation PR: plone/documentation#1696 And I thought of one more change that would be good. Since in 6.1 you need to explicitly activate the add-on, I think it makes sense to let this globally enable comments. This also helps Volto, which has no Discussion control panel where you can enable comments. After this, it would be good to have another 6.1 alpha with all the needed changes. |
|
this is done now, close? |
|
Yes. Thanks all! |
Responsible Persons
Abstract
Move
plone.app.discussionaboveProducts.CMFPlonein the dependency chain.Motivation
Most Plone sites do not need discussion/comment support.
Proposal & Implementation
plone.app.discussionfrom theinstall_requiresofProducts.CMFPlone.Plone.plone.app.discussionfor Plone 6.0.Deliverables
plone.app.discussionbranch for 6.0, and let master depend on `Products.CMFPlone.Plone, remove it fromProducts.CMFPlone@commentendpoint docs andplone.restapiupgrade guideStatus:
WIP, see plone/plone.app.discussion#211
Contributors:
The text was updated successfully, but these errors were encountered: