Skip to content

Added ambient file to support SVG ?react imports #293

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sneridagh merged 3 commits into from
Oct 19, 2025
Merged

Added ambient file to support SVG ?react imports #293

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
736bfab
Added ambient file to support SVG ?react imports
sneridagh Oct 19, 2025
a64d8c7
Remove no longer needed faked import support for ESlint file
sneridagh Oct 19, 2025
32b16c6
Changelog
sneridagh Oct 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions news/+icons_seven.feature
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Added support ?react icons in Seven add-on. @sneridagh
41 changes: 0 additions & 41 deletions templates/add-ons/seven_addon/{{ cookiecutter.__folder_name }}/.TODO-eslintrc.js
View file
Open in desktop

This file was deleted.

4 changes: 3 additions & 1 deletion ...ookiecutter.__folder_name }}/packages/{{ cookiecutter.frontend_addon_name }}/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,9 @@
"release-major-alpha": "release-it major --preRelease=alpha",
"release-alpha": "release-it --preRelease=alpha"
},
"dependencies": {},
"dependencies": {
"@plone/components": "workspace:*"
},
"peerDependencies": {
"react": "catalog:",
"react-dom": "catalog:"
Expand Down
3 changes: 3 additions & 0 deletions ... cookiecutter.__folder_name }}/packages/{{ cookiecutter.frontend_addon_name }}/types.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
// Extends module definitions to support importing SVGs as React components
// using the '?react' query parameter.
import '@plone/components/icons';