-
-
Notifications
You must be signed in to change notification settings - Fork 753
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix Protected Pages Show Blank Screen Instead of Redirecting to Login #6738
base: main
Are you sure you want to change the base?
fix Protected Pages Show Blank Screen Instead of Redirecting to Login #6738
Conversation
✅ Deploy Preview for plone-components canceled.
|
✅ Deploy Preview for plone-components canceled.
|
Hi @stevepiercy, I was thinking we could handle the issue this way. Does this approach seem correct, or am I missing something? |
@Shyam-Raghuwanshi sorry, I'm not the person to ask, as I merely review documentation for Volto. That said, I remembered this recent addition to documentation that I think is relevant to the issue. https://6.docs.plone.org/volto/configuration/how-to.html#noncontentroutes-and-noncontentroutespublic However, that only defines a set of route names, and not how to actually handle them correctly. That's about all I know. I hope that gives you a lead. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not perfect, because there are users who are logged in but don't have permission to access control panels. It's better than nothing. But, we should really figure out a consistent way to apply it to all control panel routes, not just the /controlpanel/:id
route
@davisagli Could we use the |
If your pull request closes an open issue, include the exact text below, immediately followed by the issue number. When your pull request gets merged, then that issue will close automatically.
Closes #6736