Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing source maps for maplibre-gl #7161

Closed
phb-ig opened this issue Sep 17, 2024 · 6 comments
Closed

Missing source maps for maplibre-gl #7161

phb-ig opened this issue Sep 17, 2024 · 6 comments
Assignees
Labels
bug something broken P2 considered for next cycle

Comments

@phb-ig
Copy link

phb-ig commented Sep 17, 2024

Webpack gives the following compiler warning:

Failed to parse source map from 'node_modules/plotly.js/dist/maplibre-gl-unminified.js.map' file: Error: ENOENT: no such file or directory, open 'node_modules/plotly.js/dist/maplibre-gl-unminified.js.map'

Since: 2.35.0

@junaidmzafar
Copy link

I am also seeing the same issue

@JohannSuarez
Copy link

Same here

@gvwilson gvwilson added bug something broken P2 considered for next cycle labels Sep 23, 2024
@gvwilson
Copy link
Contributor

@archmoj please dig into this - is it a configuration issue or did we miss something in the release?

@archmoj
Copy link
Contributor

archmoj commented Sep 23, 2024

We will switch from webpack to esbuild in the next minor/major version.
The esbuild PR (#6909) is already merged into master.
I think we could close this issue.
What do you think @birkskyum? If that's something you may want to fix (on top of release-2.35.3 branch), I could release it in a patch.

@birkskyum
Copy link
Contributor

birkskyum commented Sep 23, 2024

@archmoj , our default minified maplibre-gl.js has a sourcemap, so would it be an option to use that instead to resolve this? Regarding code exploration, the MapLibre GL JS repo is fully ported to TypeScript, which is stripped from the maplibre-gl-unminified.js making it a bit harder to navigate.

@archmoj
Copy link
Contributor

archmoj commented Oct 4, 2024

Addressed by #7204.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug something broken P2 considered for next cycle
Projects
None yet
Development

No branches or pull requests

6 participants