Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Could we use an actual slugify? #184

Closed
laurenskling opened this issue Aug 20, 2024 · 3 comments · Fixed by #223
Closed

Could we use an actual slugify? #184

laurenskling opened this issue Aug 20, 2024 · 3 comments · Fixed by #223
Labels
enhancement New feature or request

Comments

@laurenskling
Copy link
Contributor

If i'm correct, https://github.com/pluginpal/strapi-webtools/blob/master/packages/core/server/admin-api/services/url-pattern.ts#L242 here the plugin kebabCases the pattern, thats it.
I'd like to be able to support my current slugs, which could contain multiple slashes, making subpages.
They are deleted by the kebabCase function.
Maybe we can use @sindresorhus/slugify (like core strapi uses) and allow to set the options?

@boazpoolman
Copy link
Member

Great suggestion!

@boazpoolman
Copy link
Member

This was released with [email protected].

Thanks @laurenskling!

@laurenskling
Copy link
Contributor Author

Thanks mate

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants